Re: Some observations building gnuplot for win by gcc-4.9.2 (MinGW64)

[Ethan A M. <sf...@us...>]

On Friday, 06 March, 2015 10:54:23 Allin Cottrell wrote:
> Probably unrelated, but in looking at the gp_cairo.c code I noticed 
> one definite bug: in an error-response path in gp_cairo_convert on 
> line 750 the empty string "" is returned. Since the callers free the 
> return from gp_cairo_convert this will surely cause a segfault if it's 
> ever triggered. The return value here should either be NULL (if the 
> callers are ready to handle that), or g_strdup("").
> 
> Allin Cottrell


Good catch.
I run valgrind regularly to find such errors, but probably my
tests never execute locale-related error paths.

	Ethan