|
From: Christoph B. <us...@be...> - 2015-02-22 19:18:47
|
Am 21.02.2015 um 23:46 schrieb sfeam:
> On Saturday, 21 February 2015 10:53:53 AM Christoph Bersch wrote:
>>
>> Seems, like you committed your updated patch only to CVS, but applied my
>> old patch to the 5.0 branch.
>>
>> Check the following script, which behaves as expected with 5.1 CVS, but
>> not with the stable branch.
>
> The idea is to not break anything in 5.0.
Yes, that's why I asked. Because the current status of `set multiplot
layout margins` behavior in the 5.0 branch breaks with the behavior of
the 5.0 release version as it assumes different default units for the
values given to this option. But as long as you still have it in your
queue, it's fine :)
Another thing related to this is:
`set margin` and `set [lrbt]margin` use `char` as default unit, whereas
`set multiplot layout margins` uses `screen` as default unit. That was
the reason why I proposed to use the same behavior for all those commands.
And, the revised patch for `set multiplot layout margins` uses a sticky
`screen` or `char` keyword, so
set multiplot margins screen 0.1, 0.9, 0.9, 0.1
would use `screen` for all values, whereas
set margin screen 0.1, 0.9, 0.9, 0.1
uses `screen` only for the first value. Should we adapt the behavior of
`set multiplot margins`, so that we are consistent?
I had chosen the sticky variant, because in my use cases I always used
the same units for all values, and I didn't want to repeat the same
keyword four time (also like the coordinate parsing in `set object
polygon` does).
Best,
Christoph
|