Re: patch: qtterminal: make point plots aware of linewidth

[sfeam <sf...@us...>]

On Friday, 07 March 2014 10:50:32 AM Dieter Ries wrote:
> Hi everybody,
> 
> this is my first contribution here, so if my form or the way to send 
> this patch is wrong, please correct me.

I have it now, but please create a tracker item on the SourceForge
patch tracker and upload it there also.   That way if I lose it I
know where to find it again.  Also people can provide feedback by
attaching comments to the tracker.

> The qt terminal did not take the linewidth parameter of a plot into 
> account, when plotting 'with points'. Especially for point types 1 and 
> 2, but in general for all non-filled point types, this results in points 
> drawn with very thin lines, which tend not to be visible well when 
> printed, for example.
> 
> Attached patches change this for gnuplot 4.6.5 and latest 4.7-CVS.
> Like on other terminals, it's now possible to plot 'with points lw 2' to 
> get the points made of thicker lines.
> 
> I am not sure, if the way I implemented this is the right way, 
> especially for the more complicated QtGnuplotPoints:: way of drawing points.

I'm not sure either.   It does seem to work as advertised, but I
don't have time right now to look deeper.

In testing your patch I suddenly realize that the qt terminal is missing
the usual option "set term qt ... linewidth N".   So probably we should
add that, at which point you patch may or may not need to multiply by an
additional value, depended on how the 'set term' part is implemented.

Thanks for the patch. 

	Ethan

 
> 
> 
> Thanks in advance for feedback on these patches.
> 
> Cheers,
> Dieter