Re: X11_ymax_saved artifact in x11.trm... not

[Dima K. <gn...@di...>]

Ethan Merritt <merritt@u.washington.edu> writes:

> I suggest not to use the x11 terminal as a model for anything at all.
> It has fallen way behind the other interactive terminals.
>
> The resizing code you point to was added largely to fix the 
> long-standing problem that you could not control the aspect 
> ratio of plots displayed in x11.   If it has undesired side
> effects, that's a bug.

Right. I wrote the code in question. The x11 terminal was clearly the
main graphical terminal at one point, and it's still entangled into the
gnuplot core as a result. It was convoluted before I touched it, and
it's now even a bit more convoluted, sadly. Before my patches, the
aspect ratio control wasn't working, and fixing this was the main
purpose. It didn't make sense to clean it up because this terminal is
deprecated, so I added the extra logic without rearchitecting the whole
thing.

The main reason I care about the x11 terminal is that it was by far the
fastest of the graphical renderers when I last checked (maybe a year
ago). If you can speed up the qt or wxt terminals then the only reason
remaining to use x11 would go away.

dima