Re: X11_ymax_saved artifact in x11.trm... not

[Ethan M. <merritt@u.washington.edu>]

I suggest not to use the x11 terminal as a model for anything at all.
It has fallen way behind the other interactive terminals.

The resizing code you point to was added largely to fix the 
long-standing problem that you could not control the aspect 
ratio of plots displayed in x11.   If it has undesired side
effects, that's a bug.

	Ethan



On Saturday, 08 March 2014 06:37:03 PM Daniel J Sebald wrote:
> On 03/08/2014 06:31 PM, Daniel J Sebald wrote:
> 
> > [I wonder why
> >
> > X11_ymax_saved = (double)term->xmax * (double)ge->my /
> > fabs((double)ge->mx);
> >
> > is being done in response to a GE_fontprops command. Is GE_fontprops
> > somehow guaranteed to happen if the user uses the mouse to resize the
> > X11 window? I then ask if caching the window size actually saves
> > anything if this code in do_event() is being accessed more than
> > X11_graphics() is, which in both cases might not be all that often.]
> 
> In fact, this window size caching has a bug, depending upon perspective. 
>   Try the following:
> 
> gnuplot> set term x11 1
> Terminal type set to 'x11'
> Options are '1 nopersist enhanced'
> gnuplot> plot x
> [shrink the window size using the mouse to something small]
> gnuplot> set term x11 2
> Terminal type set to 'x11'
> Options are '2 nopersist enhanced'
> gnuplot> plot x**2
> 
> The second window is created with small size when perhaps it should be 
> the default window size.  Is that what should happen?  If not, somewhere 
> in the options code should be something that changes the cached value 
> back to the default window size.  That, or perhaps remove caching if it 
> doesn't amount to very much.  Right now is it a mix of mouse driven 
> changes to term->xmax and query requests for xmax and ymax?
> 
> Let me know how you think this should be fixed and I will change the Qt 
> terminal in the same way as I'm trying to address the Qt size retention 
> issue right now.
> 
> Dan