|
From: Daniel J S. <dan...@ie...> - 2014-03-08 08:26:53
|
On 03/07/2014 04:43 PM, Jon Gjengset wrote: >> As for areas for refactoring: > > Not sure how much has changed in the image mode handling code recently, > but I keep running into issues with image mode. In particular: > > - Visible pixel grid has a scan line longer than previous scan lines. > - Number of pixels cannot be factored into integers matching grid. N = ... K = ... > > Improving the robustness of the image handling code would certainly be a > welcome change, even if the input syntax for images would have to change > (not sure that it would need to though, as "failsafe" is usually enough > fix the problem). I'm open to the idea. Ethan and I agreed on a message in the configure indicating that image scripts were experimental. Not sure why it is no longer robust...used to be, albeit finicky syntax. The big challenge was compatibility with the existing gnuplot binary and the df_readline() routine. That really put things in a bind, partly because the gnuplot binary was so basic that it became restrictive to work around it. Someone mentioned reviewing code quality. There are many things that could be done better. Organization of the main plotting routines for more clarity would be a good start. A way to re-read data for individual plots. Remove all global variables (almost had all of them at one point, but more keep finding their way in). The date code, but that one's not for mortals. Many more. But I think before embarking on this, it takes some good planning. Dan |