|
From: Mojca M. <moj...@gm...> - 2014-02-10 23:39:31
|
On Mon, Feb 10, 2014 at 5:51 PM, sfeam wrote:
> On Monday, 10 February 2014 12:37:23 PM Mojca Miklavec wrote:
>> Also, now that there is no more forking involved, please delete
>> src/qtterminal/qt_term_mac.m
>> as well as the corresponding lines in Makefiles.
>
> The program still forks. The only change is that fork() is perforned via
> a Qt library routine rather than being invoked in-line.
Nonetheless that doesn't change my request to remove that code. Even
if forking is still present, it is now apparently done in such a way
that it doesn't confuse Qt any longer.
I'm attaching a patch. It nearly reverts the following commit:
2012-06-23 Jérôme lodewyck <lod...@us...>
* configure.in src/Makefile.am src/qtterminal/qt_term.cpp
src/qtterminal/qt_term_mac.m: Proper handling of the qt terminal dock
icons on Mac OS
(I'm saying nearly because some of the changes were already present in
the commit from 2012-01-17.)
The whole point of that code (mostly requested by me) was an ugly
workaround for problems related to the way forking was previously
implemented. I can do more testing, but it looks as if that particular
problem is gone.
Mojca
|