Re: Reworked qt terminal is much faster – and fails to work on Mac

[Mojca M. <moj...@gm...>]

On Sun, Feb 9, 2014 at 12:45 AM, sfeam wrote:
> On Saturday, 08 February 2014 04:59:23 PM Daniel J Sebald wrote:
>>
>> Looking at the code, it seems that the printout above might be in error.
>>   I see the following:
>
> You are right.  The debug statement dumps the wrong string.
>
> Mojca:
>
> Please apply the following additional patch and repeat your experiment:
> %%%%%%%%%%%%%%%%%
> --- gnuplot/src/qtterminal/qt_term.cpp  2014-01-26 13:57:10.687171903 -0800
> +++ gnuplot-cvs/src/qtterminal/qt_term.cpp      2014-02-08 15:33:45.873131386 -0800
> @@ -273,7 +274,7 @@ void qt_connectToServer(const QString& s
>                 // The gnuplot_qt program could not be reached: try to start a new one
>                 else
>                 {
> -                       qDebug() << "Could not connect gnuplot_qt" << qt_option->Widget << ". Starting a new one";
> +                       qDebug() << "Could not connect gnuplot_qt" << server << ". Starting a new one";
>                         execGnuplotQt();
>                         qt_connectToServer(qt->localServerName, false);
>                 }
> %%%%%%%%%%%%%%%%%%

Yes, this does the right thing (of course it only affects reporting
the right value, not the functionality).

> Now here's an interesting thing.  I can get approximately the same behavior
> under linux that you report under OSX by deliberately setting GNUPLOT_DRIVER_DIR
> to an incorrect directory.   So to be on the safe side, could you please set
> this environmental variable even though it should be redundant?

I tried setting it to all values I could think of ($PWD/src,
$PWD/inst/bin, $PWD/inst/libexec/gnuplot/4.7). It did switch to a
different "gnuplot_qt" binary in the first case, but no change.

> Another possible test:
> Change the timeout value on line 259 from
>                qt->socket.waitForConnected(200);
> to
>                qt->socket.waitForConnected(-1);
>
> This could potentially cause gnuplot to hang, but it also might work :-)

Gnuplot runs at 99% CPU with or without that change (just gnuplot,
gnuplot_qt doesn't consume any CPU at all after the first few
seconds).

Mojca