Re: [PATCH] The autoscaling of images during volatile data refresh works again

[Dima K. <gn...@di...>]

Ethan Merritt <merritt@u.washington.edu> writes:

> On Friday, 05 April 2013, Dima Kogan wrote:
>> I'm attaching a patch that fixes another set of issues with refreshing
>> volatile data: autoscaling of images.
>
> I very much dislike that factor of 1e-3.  A better fix would remove it altogether.
> How about the attached patch instead.

Sounds great. I'm not a fan of that either.


>> Re-enabling the first two commented-out lines in the test case reveals
>> yet another set of issues. I'll look at those in a bit.
>
> The remaining problem I see is shown by adding to your test script
> set x2tics
> set y2tics
>
> Since there is no x2 or y2 data the autoscaling on those axes
> never happens, leading to an error equivalent to the one you
> found.  Possible fixes:
>
> If the axis min/max is still set to the initial autoscaling magic
> constants +/-VERYLARGE either
>   1) don't try to draw tick marks or
>   2) clone primary axis limits into secondary axis

Looks like you fixed this in the repo. Thanks!

dima