Re: [PATCH] volatile-data plots now handle 'reversed' ranges during replots

[Ethan M. <merritt@u.washington.edu>]

On Wednesday, April 03, 2013 12:46:23 pm Dima Kogan wrote:
> Ethan Merritt <merritt@u.washington.edu> writes:
> 
> > On Wednesday, April 03, 2013 02:57:01 am Dima Kogan wrote:
> >> I'm attaching another patch. This one adds support to the "reverse"
> >> ranges setting for replots of volatile data. This is similar to the
> >> previous ranging fixes, where the setting was respected for the original
> >> plot, but ignored for replots.
> >> 
> >> I'm also including the test cases I used to validate this. For all the
> >> test cases, I made sure that both the original plot and a replot looked
> >> good.
> >
> > I'm not seeing any difference between the patched and the unpatched
> > behavior.  Could you give me a specific set of instructions to test,
> > inclding any mouse or replot/refresh commands?
> >
> > Both the patched and unpatched code versions lose track of the "reverse"
> > setting after an unzoom operation using the "u" hotkey.
> 
> That's odd. I just tried again with a clean checkout, and the patch
> seems to work, both through replots ('e' key) and zoom/unzoom (mouse and
> 'u' key). 

I must have gotten confused as to what patches had been applied
to the version I was testing.  It all looks good now that I have 
started from a clean copy.

	Ethan




> The tree I'm looking at has both of the patches I sent
> yesterday, so the last few commits are titled
> 
>  document use of "smooth frequency" to generate and plot a histogram
>  Allow level 1 PostScript interpreters to skip large (>64kB) embedded images
>  x11 terminal: corrected some sizing inconsistencies
>  volatile-data plots now handle 'reversed' ranges during replots
> 
> After the tree is checked out, I do
> 
>  export GNUPLOT_DRIVER_DIR=$PWD/src
>  ./prepare && ./configure && make -j2 && src/gnuplot
> 
> Then inside gnuplot, I load one of the testcases
> 
>  load "/tmp/testcases/reverse_keywordspec.gp"
> 
> Then I press 'e' to replot, do some zooming with the mouse, and press
> 'u' to unzoom. The right answer is a downward sloping line (reversed y
> axis). I see this even through 'e' and zoom/'u'. Before the attached
> patch only the initial plot looked right.
> 
> dima
> 
> ------------------------------------------------------------------------------
> Minimize network downtime and maximize team effectiveness.
> Reduce network management and security costs.Learn how to hire 
> the most talented Cisco Certified professionals. Visit the 
> Employer Resources Portal
> http://www.cisco.com/web/learning/employer_resources/index.html
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
> 

-- 
Ethan A Merritt
Biomolecular Structure Center,  K-428 Health Sciences Bldg
University of Washington, Seattle 98195-7742