|
From: Ethan M. <merritt@u.washington.edu> - 2013-04-03 16:51:37
|
On Wednesday, April 03, 2013 02:57:01 am Dima Kogan wrote: > I'm attaching another patch. This one adds support to the "reverse" > ranges setting for replots of volatile data. This is similar to the > previous ranging fixes, where the setting was respected for the original > plot, but ignored for replots. > > I'm also including the test cases I used to validate this. For all the > test cases, I made sure that both the original plot and a replot looked > good. I'm not seeing any difference between the patched and the unpatched behavior. Could you give me a specific set of instructions to test, inclding any mouse or replot/refresh commands? Both the patched and unpatched code versions lose track of the "reverse" setting after an unzoom operation using the "u" hotkey. Ethan > > Lastly, I'm really not at ease with these patches. Currently there are > separate code paths for volatile and from-a-file data; these paths get > out of sync, and issues such as this arise. I'm assuming that where > reading data from files gnuplot can (and does) take multiple passes > through the data, which is impossible when reading a pipe. Does anybody > know why multiple passes are made? Is it a major undertaking to reduce > this to a single pass, so that all data becomes "volatile" and we can > get rid of the multiple code paths? > > dima > > -- Ethan A Merritt Biomolecular Structure Center, K-428 Health Sciences Bldg University of Washington, Seattle 98195-7742 |