Re: Any issues that would hold up release of 4.6.1?

[Mojca M. <moj...@gm...>]

On Tue, Sep 18, 2012 at 8:48 PM, Ethan A Merritt wrote:
>
> === emacs ===
>> Mojca Miklavec <moj...@gm...>
>> Not a major showstopper, but I would be grateful if someone could take
>> a look at the attached patch for emacs (and apply before the release
>> it if possible). The problem is that setting
>>     EMACS=/path/to/some/Emacs ./configure
>> is later "reset" with
>>     EMACS=`basename $EMACS`
>> in lisp/configure[.in], so version checking and all further
>> emacs-related operation fail to work properly since they call whatever
>> emacs/xemacs comes first in PATH instead of the one requested by user.
>
> I am very reluctant to make changes to the configuration system for 4.6.1
> that have not previously been tested in the development tree.
> That said, I am willing to have a look at this if you can you clarify
> what the problem actually is.

To understand the problem better please try the following
    ln -s /usr/bin/emacs /tmp/myemacs
    EMACS=/tmp/myemacs ./configure

> Which of these is happening?
>
> 1) you have an "emacs" in your path that is incapable of compiling the
>    three files gnuplot.elc gnuplot-gui.elc gnuplot-eldoc.elc?
> 2) The version check to see if emacs is older than version 20.3 fails?
> 3) The *.elc files are compiled properly but installed in the wrong
>    site-lisp directory?

In my case none of the above. But two other things go wrong:
1.) The code
    if test "$EMACS" = emacs ; then
doesn't recognize uppercase "Emacs". There's nothing wrong with that
since I'm not interested in the patch anyway, but the "else" part
doesn't reset
    INFO_LOOK_ELC=
so after
    EMACS=/Applications/Emacs.app/Contents/MacOS/Emacs
../gnuplot/configure && make
I end up with

Wrote /tmp/gnuplot-build/lisp/gnuplot.elc
Emacs -batch -q -no-site-file -l ../../gnuplot/lisp/dot.el -f
batch-byte-compile gnuplot-gui.el
Wrote /tmp/gnuplot-build/lisp/gnuplot-gui.elc
make[2]: *** No rule to make target `info-look.elc', needed by `elcs'.  Stop.
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

2.) Version checking is either done with the wrong EMACS binary, or
not at all (if that binary is not the first one with the same name in
path). Gnuplot first accepts user's explicit request to use a specific
binary like
    /Applications/Emacs.app/Contents/MacOS/Emacs
in my case, but then tries to call
    Emacs --version
which either uses /usr/bin/emacs or /opt/local/bin/emacs (a different
binary) from PATH or completely fails in case of case sensitive file
systems. In the example I suggested above compilation breaks with

./doc2gih ../../gnuplot/docs/gnuplot.doc gnuplot.gih
Making all in lisp
myemacs -batch -q -no-site-file -l ../../gnuplot/lisp/dot.el -f
batch-byte-compile gnuplot.el
make[2]: myemacs: No such file or directory
make[2]: *** [gnuplot.elc] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2


> As to (2) is any of this still needed?  The README says that the
> info-look.xxx files are a work-around for incompatibilities in ancient
> versions of emacs and Xemacs.  Can we just get rid of these files and
> get rid of that section of the Makefile?

(I wanted to suggest that, but didn't dare to.)

Mojca