Re: gnuplot 4.4rc1-CVS binaries for windows, djgpp and cygwin are uploaded

[Ethan M. <merritt@u.washington.edu>]

On Monday 22 February 2010 17:38:10 Tatsuro MATSUOKA wrote:
> Hello
> 
> Thanks for the fix.
> 
> I have confirmed the fix on the gnuplot 4.5 (CVS).
> 
> 2010-02-22  Don Taber  <dt...@to...>
> 
> 	* src/win/wgraph.c (SelFont):  After a font change, call 
> 	do_string_replot("") so that it is immediately visible.
> 
> On the 4.4cvs, the above fix cannot be found.  I would like to just confirm that whether the patch  is
> applied only to the 4.5.  

Yes.  I was reluctant to put it in the 4.4 cvs so close to release date.
But if people think it is important, and won't break anything, I can add it.

	Ethan


> 
> Regards
> 
> Tatsuro
> 
> --- don taber  wrote:
> 
> > > > One problem I note in both cases: Font changes made with the "Choose
> > > > Font" Windows dialog do not take effect unless followed by a replot
> > 
> > > > There is something missing from the code that redraws the plot when
> > > > the dialog is closed.  I'm sure that someone who is more of a Windows
> > > > programmer than I can fix this easily.
> > > 
> > > No, there is nothing missing in the code that redraws the plot.
> > > And I'm not sure this can be easily fixed.
> > > 
> > > This is a manifestation of a principal problem in gnuplot's plotting 
> > > algorithm.
> > > 
> > 
> > Benjamin,
> > 
> > Thanks for the explanation of why the current code needs
> > the replot.  This analysis seems to suggest that my (revised) patch
> > calling do_string_replot(), as suggested by Ethan, is
> > the best solution.
> > 
> > Don Taber