Re: Choose Font issue? in the dialog of the graph window of windows terminal

[Ethan M. <merritt@u.washington.edu>]

On Monday 22 February 2010 08:58:46 don taber wrote:
> > "don taber" wrote :
> > ======================================================================
> > One problem I note in both cases: Font changes made with the "Choose
> > Font" Windows dialog do not take effect unless followed by a replot
> ...
> > 
> > Any suggestions?
> 
> The appended patch fixes the problem for me.  I general, I think
> it should be okay because you cannot get to that dialog unless
> you have already successfully performed a plot.  So replotting
> should succeed.  

Careful.  It may not work for volatile input data, e.g. 
in-line data typed from the command line.

> The only abberant case I have found is to 
> splot a 3d surface and then issue a bad 2d plot command.
> Now replotting fails because (I think) the 'is_3d_plot' variable got 
> changed by the bad plot command.
> 
> Don Taber

It would probably be better to set up a call to do_string_replot()
rather than to call replotrequest() directly.  The routine tests
for the presence of volatile data and then calls either refresh_request()
or replotrequest() as appropriate.

There may well be other places that the same care should be taken.
I am not sure the windows terminal driver was ever audited for this
when the refresh/replot distinction was introduced.

	(working off pure logic here, I haven't tested the code)

		Ethan


> ------------------------------------------------------------
> 
> 
> --- wgraph.c.orig	2010-02-19 11:17:11.000000000 -0800
> +++ wgraph.c	2010-02-19 11:17:37.000000000 -0800
> @@ -815,6 +815,7 @@
>  		strcpy(lpgw->deffontname,lpgw->fontname);
>  		lpgw->deffontsize = lpgw->fontsize;
>  		SendMessage(lpgw->hWndGraph,WM_COMMAND,M_REBUILDTOOLS,0L);
> +		replotrequest();
>  	}
>  #endif
>  }
> 
> ------------------------------------------------------------------------------