Re: gp_cairo.c patch for win32

[Allin C. <cot...@wf...>]

On Thu, 5 Nov 2009, Ethan Merritt wrote:

> On Thursday 05 November 2009 10:57:59 Allin Cottrell wrote:
> > Attached: request that pango/cairo use its FreeType + fontconfig
> > backend when operating on MS Windows.
> >
> > Note: the patch doesn't seem to do any harm on Linux, but perhaps
> > should be made conditional on compilation for Windows.
>
> Doesn't build for me under linux:
>
> wxterminal/gp_cairo.c: In function ‘gp_cairo_create_layout’:
> wxterminal/gp_cairo.c:705: warning: \
implicit declaration of function ‘pango_font_map_create_context’

Ah, in the pango docs it says that this is new since pango
version 1.22.  Maybe conditionalize the relevant line as:

#if PANGO_VERSION_MAJOR == 1 && PANGO_VERSION_MINOR < 22
  context = pango_cairo_font_map_create_context(fontmap);
#else
  context = pango_font_map_create_context(fontmap);
#endif

(The first forulation above is now "deprecated".)

Allin Cottrell