Re: Hot key to toggle log scale is broken

[Petr M. <mi...@ph...>]

> > The 'l' was one of the hotkeys firstly implemented; it switches the log
> > scale of what axis the user expects and uses most frequently.
> 
> "what the user expects" clearly must depend on the user :-)

The behaviour I vote for is there for ages, and thus I assume it is 
comfortable with everybody.

> This user expects the key to work on the cb mapping, regardless of the
> current Z range.  Since we are viewing in projection, why should the
> Z range matter?

You typically "splot 'a.dat' u 1:2:3", thus z=cb.

"set log z" invalidates only non-positive z-points, which the pm3d mode 
handles natively; "plot with image" cannot handle this.

> The traditional case assumed that z=cb. This is no longer true.

It is, see above.

> Why should the hotkey act differently depending on whether you
> drew the graph with "plot" or "splot"?  Since you can now use palette
> and other coloring options in both 2D and 3D, this seem to me an
> artificial distinction.

The pm3d mode does not work in "plot".

On the other hand, "splot ... with image" + set log z reports errors.

> Users who run a script written elsewhere may not even know whether the 
> plot they are looking at on the screen was created by 'plot' or 'splot'.  
> They shouldn't have to;  the hotkeys should behave consistently for both 
> cases.

When 2D plots are unified ... then what to do with 3D splots and the 'l' 
hotkey? Will it flip both z+cb? 

> There are at least 2 other problems:
> 
> 1) 2D plots can now use palette colors.  I don't think it is reasonable to
> have 'l' toggle y some times and z+cb at other times, depending on
> which coloring schemes are in use for the current plot.

right
but there is no clue for this, as nowadays there can be any mix of plots

> 2) 2D plots created either with 'plot' or 'splot' may have a positive
> range on cb, but not on z.

but not for 'plot'

>  If 'l' tries to toggle log-scale on z it will fail, even though it 
> wouldn't have affected the appearance of the plot anyhow.  Better it 
> should only try to toggle cb.

it fails only for "splot ... with image"

> Would it be compatible with your previous usage to toggle cb only?
> I imagine your old plots have z=cb, and in projection you cannot see z.

The z is usefuly "only" to invalidate points for non-positive z (make the 
pm3d plot transparent). 

> Alternatively,  suppose we change it so that 'l' always tries to
> toggle z+cb .  What should  happen if the z range goes negative? 
> Should it toggle cb only, and give an error message?  No error message?
> Not do anything?


> If 'l' toggles cb (with or without z) in 2D,  how is the user supposed to
> toggle y instead?

in "set view map", you would use 'L'


In summary:

In "plot": 
     A. 'l' does "set log y" ... this is the current behaviour
     B. 'l' does "set log cb" only if there are only
	'with image' plot(s), otherwise "set log y"

Option B. would need a clever patch.


In "splot": 
     A. 'l' does "set log z+cb" for both 3D and "view map"
	 ... this is the current behaviour
     B. 'l' does:
	"set log cb" in "view map" if there is a palette plot,
	  otherwise "set log z"
	"set log z+cb" in 3D
     C. 'l' does "set log cb" in "view map" and "set log z+cb"
	 in 3D without "with image" and "set log cb" if there is some
	 "with image" at non-positive z-coordinates


Opinions?

--- PM