Re: Hot key to toggle log scale is broken

[Ethan M. <merritt@u.washington.edu>]

I have made a further adjustment to the 'L' hotkey, which I hope addresses
your concerns.  Please use the new demo plot (last plot in 'heatmaps.dem')
to see how this works in "set view map" mode:
  If cursor is in color box, toggle log cb
  If cursor is near x1 axis, toggle log x1
  If cursor is near y1 axis, toggle log y1
  If none of the above, toggle log z

The behavior of the 'l' hotkey in "set view map" mode is still a sore point.
It now does what the documentation always said:  it toggles y1.
But it used to toggle z+cb.  This was broken (see last demo in heatmaps.dem).
It would be easy to make it toggle either z or cb instead, and change the
documentation to match.  But I think it should not toggle both of them.
You may disagree.

I am wondering why there is a need for both 'l' and 'L'.
Is there a particular case where the distinction is necessary?

	Ethan

On Wednesday 04 June 2008 07:32, Ethan A Merritt wrote:
> On Tuesday 03 June 2008 23:49, Petr Mikulik wrote:
> > > > > I propose to restrict the effect of 'l' and 'L' to the X,Y axes in 2D
> > > > > and the Z axis in 3D.  We can add another hotkey, probably 'c', to 
> > > > > explicitly toggle log scaling on the colorbar in both 2D and 3D plots.
> > > > 
> > > > I don't think we need a separate hotkey.  'l' only acts on the axis the 
> > > > mouse is close to.  So it should act on the cb axis only if the colorbox 
> > > > is visible, and the mouse is inside it.
> > > 
> > > That "axis the mouse is close to" works only in 2D.
> > > In 3D the hotkey always toggles Z no matter where the mouse is.
> > > 
> > > But yes, we could change it to check where the colorbox is in both 2D and 3D.
> > 
> > In 2D, it works OK.
> > 
> > However, the 'l' hotkey is completely broken in 3D. It should (un)log both Z 
> > and CB axes, not only one of them.
> 
> No, it should not.  That is exactly what I am trying to fix.
> Long ago, Z and CB tracked the same quantity and it was reasonable to
> treat them jointly.  This is no longer true.
>  
> >The hotkey 'L' should be selective to Z 
> > or CB according to position of the mouse cursor -- it's ok now.
> 
> > Another broken example:
> > 
> > gnuplot> set pm3d map
> > gnuplot> splot x*x+y*y+1
> > gnuplot>          y range has y coord of -10; must be above 0 for log scale!
> > 
> > I.e., the 3D hotkey functionality for 'l' should work as before the patch, 
> > while the 'L' works correctly now.
> 
> The documentation has always said that 'l' toggles the Y axis in
> 2D plots.  This was untrue, because it toggled Z + CB instead in a 
> case such as the one above.  The new code does what the documentation
> has always said: toggles the Y axis. 2D and 3D plots now behave 
> uniformly.  The hotkeys toggle the cb scaling if and only if the mouse
> is near the color bar.
> 
> -- 
> Ethan A Merritt
> 

-- 
Ethan A Merritt            Courier Deliveries: 1959 NE Pacific
Dept of Biochemistry       Regular Mail: Mailstop 357742
Health Sciences Building
University of Washington - Seattle WA 98195-7742