|
From: Petr M. <mi...@ph...> - 2008-04-10 21:42:51
|
> On Wed, Apr 2, 2008 at 8:49 AM, Petr Mikulik <mi...@ph...> wrote: > > Michael has managed to have working console, thus not GUI, version of > > gnuplot for Octave. He calls it pgnuplot. I think this matter should be > > discussed on the gnuplot mailing list: > > > > - this definitely needed unpublished patches into gnuplot source code > > I maintain a patch for gnuplot in octave-forge > (admin/Windows/msvc/libs/gnuplot-4.2.2.diff). I already posted a bug report > and a patch on the gnuplot patch system months ago. Up to now, nothing has > been integrated into the gnuplot source tree. If the gnuplot developers are > interested, they can still contact me. Your patch for gnuplot [ 1627936 ] Gnuplot Win32 in console mode http://sourceforge.net/tracker/index.php?func=detail&aid=1627936&group_id=2055&atid=302055 is dated Janury 2007. >From the above, it seems you maintain your patch somewhere inside the octave forge cvs tree. Hm, it has taken me long clicking to find it at http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/admin/Windows/msvc/libs/gnuplot-4.2.2.diff?view=annotate (I have no idea how this patch can be useful as this patch is not inside the package windows-1.0.4.tar.gz, but that's an Octave-forge problem.) >From previous mails from Tatsuro MATSUOKA, I've got an impression the patch you maintain is for gnuplot 4.3 because of the "refresh" command, but it's actually for 4.2.2, right? I've tried it, and there are rejects for both 4.3cvs and 4.2.3. In order to propagate your work into the gnuplot source code, I propose: - you move the work on the patch to gnuplot's Patches: [ 1627936 ] Gnuplot Win32 in console mode - do you prefer to work on the patch for 4.2.3 or for 4.3cvs? - you should split the patch into three independent parts: - the wxt-MSW patches -- to be discussed with the authors of wx terminal, put into cvs independently - the OCTAVE_BUILD default settings -- another way how to set its defaults should be found - the core of your patch - please add patches to makefile.mgw so that others can compile it by the MingW compiler - after reading some mails and the patch description in #1627936, I wonder whether it is console or console-less version? I.e., does it look like the OS/2 or Unixish gnuplot when you run it? (You can enter commands via readline from the command console, and stdin piping works too.) Or is there no console (nor textual nor graphical) and commands can go only from stdin? - If it is a pipe-only wgnuplot, then it should be really called "pgnuplot", not gnuplot. > I used pgnuplot, because this is the program the octave's configure script > is looking for under Windows platform. And also other Windows programs using gnuplot drawing engine expect pgnuplot.exe, so let's keep the name. Greetings, Petr |