[Gnuplot-info] still issues with building latest gnuplot version on opensuse

[Dieter J. <die...@t-...>]

Dear listmembers,
dear Mr. Broeker,

I yelled "ok" too early. It is not ok.

The build process runs ok.

However:
The file /usr/share/X11/app-defaults/Gnuplot is not found due to the fact that 
the path to the app-defaults directory is hard-coded in src/gplt_x11.c

It cannot be handed over via src/Makefile.am because the commandline define is 
being overridden in gplt_x11.c

The minimum change required is to put a
#ifndef AppDefDir
#define AppDefDir="/usr/lib/X11/app-defaults"
#endif /* AppDefDir */

into gplt_x11.c.

However, IMHO you should not be forced to double-specify the very same 
parameter: in src/Makefile.am as -DAppDefDir=<anyplace/anywhere> _and_ in

make appdefaultdir=<anyplace/anywhere> install.

Moreover from a convention standpoint I would suggest changing the name

#define AppDefDir 

into 

#define APPDEFAULTDIR

for consistency reasons.

Migth be a good idea to put this into config.h anyway and make Makefile.am 
aware of what has been defined - if it has been defined. The way it is now is 
not what I would consider consistent.

Thank you for looking into this,
take care




Dieter Jurzitza

FYI - configuration results:

######### see this line below for end of configuration information #######
+ touch configure.in
+ rm -f config.status config.log config.cache configure aclocal.m4
+ aclocal -I m4
+ autoconf
+ ./configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --libexecdir=/usr/lib --datadir=/usr/share --with-gcc\
 --with-x --x-includes=/usr/include --x-libraries=/usr/lib --with-readline=gnu --enable-history-file --with-linux-vga --with-gif=png\ 
 --with-freetype=/usr/lib --enable-x11-mbfonts --enable-h3d-quadtree --with-zlib --with-gd --enable-thin-splines --without-row-help\
 --with-kpsexpand --with-plot=/usr/lib 

giving the following configuration results:

** Configuration summary for gnuplot 4.2.3:

gnuplot will be compiled with the following terminals:

  Standalone terminals: yes (always builtin)
    (aed512, aed767, aifm, bitgraph, cgm, corel, dumb, dxf, eepic, emf, emtex,
    epslatex, epson_180dpi, epson_60dpi, epson_lx800, fig, gpic, hp2623A,
    hp2648, hp500c, hpdj, hpgl, hpljii, hppj, imagen, kc_tek40xx, km_tek40xx,
    latex, metafont, metapost, mif, pbm, postscript, pslatex, nec_cp6, 
okidata,
    pcl5, pstex, pstricks, qms, regis, selanar, svg, starc, tandy_60dpi,
    tek40xx, tek410x, texdraw, tgif, tkcanvas, tpic, vttek)
  x11/xlib terminal: yes (with mouse support)
    (with multi-byte fonts)
    (with binary polygon protocol (EXPERIMENTAL))
  jpeg terminal: yes
  gif terminal: yes (with animated gif)
  png terminal: yes
    (jpeg, gif and png terminals can use TTF fonts)
  pdf terminal: no (requires libpdf)
  plot library terminal: yes (gnugraph - GNU version)
  linux terminal (vga console): no (use --with-linux-vga to enable,
                                       requires SVGAlib)
  vgagl terminal ((s)vga console): no (use --with-linux-vga to enable,
                                       requires SVGAlib with vgagl)
  ggi terminal: no (use --with-ggi to enable, requires libggi)
  iris4d terminal: no (use --enable-iris to enable, requires libgl_s)
  mgr terminal: no (use --enable-mgr to enable, requires libpixrect)
  rgip/uniplex terminal: no (use --enable-rgip to enable)
  svga terminal (MSDOS/djgpp): no
  be terminal (BeOS): no
  next terminal: no
  aqua terminal (MacOS X): no
  wxt terminal: yes (EXPERIMENTAL)

  Additional terminals are availaible in platform-specific makefiles:
   amiga (makefile.amg and makefile.ami), apollo/gpr (makefile.unx), atari/vdi
   (makefile.st), cgi (makefile.unx), mtos (makefile.mto), pm (makefile.os2),
   sun (makefile.unx), unixpc (makefile.unx), windows (various Windows
   makefiles)
  Additional terminals are built automatically if possible at compile-time:
   vesa (MSDOS), emxvga (MSDOS, OS/2), ega/vga/svga/ssvga/hercules (Windows 
with
   Zortec compiler), macintosh

gnuplot will be compiled with the following features:

  Fitting error variables: yes
  String-handling in datafiles: yes
  Plot style histograms: yes
  String variables: yes
  Command line macros: yes (EXPERIMENTAL)
  Placement of rectangles and other objects: yes (EXPERIMENTAL)
  Plot style image: yes (EXPERIMENTAL)
  General binary data file reading: yes (EXPERIMENTAL)

gnuplot will be compiled with the following options:

  Readline library: GNU readline library with  -lncurses
  Command-line history file: yes
  Check current directory for .gnuplot file: no (use --with-cwdrc to enable)
  Sort help/subtopic tables by column: yes
  Use TeX kpsexpand to search for fonts: yes
  Thin plate splines: yes
  Hidden3d optimization: quadtree
  Deprecated syntax and terminal options : yes

gnuplot will install the following additional materials:

  lasergnu printer script: no (use --with-lasergnu to enable)
  gnuplot-mode for X/Emacs: yes
  LaTeX tutorial: yes
  Help file: yes (always), in /usr/share/gnuplot/4.2/gnuplot.gih
  PostScript prologue files: yes (always)

and installing 

make DESTDIR=$RPM_BUILD_ROOT appdefaultdir="/usr/share/X11/app-defaults" 
install
######### see this line below for end of configuration information #######


-- 
-----------------------------------------------------------

                               |
                                \
                 /\_/\           |
                | ~x~ |/-----\   /
                 \   /-       \_/
  ^^__   _        /  _  ____   /
 <°°__ \- \_/     |  |/    |  |
  ||  ||         _| _|    _| _|

if you really want to see the pictures above - use some font
with constant spacing like courier! :-)
-----------------------------------------------------------