Re: cairo terminals and aspect ratio

[<tim...@lp...>]

Timothée Lecomte a écrit :
> Timothée Lecomte a écrit :
>   
>> Ethan A Merritt a écrit :
>>   
>>     
>>> On Monday 19 November 2007 23:23, you wrote:
>>>   
>>>     
>>>       
>>>>> It looks like the aspect ratio code is broken in
>>>>> all of the cairo-based terminals including wxt.
>>>>>       
>>>>>         
>>>>>           
>>>> term->xmax and term->ymax are updated in *_graphics(), the latter also 
>>>> calls *_set_font() which sets term->h_tic, v_tic, v_char, h_char, based 
>>>> on the font size.
>>>>
>>>> For me it works:
>>>>
>>>> set term wxt
>>>> set size square
>>>> set polar
>>>> plot 1
>>>>
>>>> ...gives a square circle.
>>>> Could you give the whole sequence of commands you use ?
>>>>     
>>>>       
>>>>         
>>> lascaux [1007] ./gnuplot
>>>
>>>         G N U P L O T
>>>         Version 4.3 patchlevel CVS-16Nov2007
>>>         last modified Sun Nov 18 20:51:17 PST 2007
>>>         System: Linux 2.6.12-24mdksmp
>>>
>>>         Copyright (C) 1986 - 1993, 1998, 2004, 2007
>>>         Thomas Williams, Colin Kelley and many others
>>>
>>>         Type `help` to access the on-line reference manual.
>>>         The gnuplot FAQ is available from
>>>                 http://www.gnuplot.info/faq/
>>>
>>>         Send comments and help requests to  <gnu...@li...>
>>>         Send bug reports and suggestions to <gnu...@li...>
>>>
>>>
>>> Terminal type set to 'wxt'
>>> gnuplot> set size square
>>> gnuplot> plot sin(x)
>>> gnuplot> set term pngcairo
>>> Terminal type set to 'pngcairo'
>>> Options are ' size 640, 480 '
>>> gnuplot> set output 'pngcairo_1.png'
>>> gnuplot> replot
>>> gnuplot> show size
>>>
>>>         size is scaled by 1,1
>>>         Try to set aspect ratio to 1:1.0
>>>
>>>   
>>>     
>>>       
>>>> And it works in pfdcairo and pngcairo too...
>>>>     
>>>>       
>>>>         
>>> I got your command sequence to work using a 1 Aug 2007 build
>>> from CVS, but it does not work using the current cvs. 
>>> Something must have broken.   
>>>
>>> I guess I'll have to sample from the cvs tree for the last 
>>> 3 months and see what happened.
>>>   
>>>     
>>>       
>> Hmm, I just tried with current CVS and I get the said problem. The 
>> previous version I had was only a few days old.
>>
>> Timothée
>>     
> Ok, found the typo ! I'll commit the fix as soon as I come back from my 
> meeting tonight.
>
> Timothée
>
>   
I have commited the fix to CVS. For those of you who want to have it 
right now instead of waiting for the anonymous CVS to be updated, just 
change the following line in src/wxterminal/gp_cairo.c (around line 1663):

tmp_h_tic = tmp_h_char/2.5;

to

tmp_h_tic = tmp_v_char/2.5;

Sorry for this error, and thanks for reporting !

Best regards,

Timothée Lecomte