|
From: Petr M. <mi...@ph...> - 2007-06-14 08:10:04
|
> >>- [ 1731160 ] min/max printout error for show Xrange > >> fine, I propose to move it to cvs > > > > No. I don't think the issue is well understood. > > There may be an error, but I am not so sure. > > Isn't this what the "writeback" option is supposed to handle? > > Do we have a test case for "writeback"? > > I misunderstood this one when writing this patch. I took it to mean > GPVAL_Y_MIN, GPVAL_Y_MAX, etc. So, there is no error from the perspective I was > saying. > > set yrange [ * : * ] noreverse writeback # (currently [-10.0000:10.0000] ) > should change to reflect something. > > I thought maybe the [-1:1] would show in the "currently [ : ]", but there is no > reason for gnuplot to display anything different than it currently does. > > I'm inclined to close this patch. However, maybe if there is one thing to > change it would be the word "currently" to "default", i.e., I was always puzzled by "currently [-10:10]" when the range was completely different. Indeed, "default" is the correct word. However, this information is completely useless. I usually want to show the real xrange, not the unused default. Nowadays, I can do print GPVAL_Y_MIN, GPVAL_Y_MAX but that's rather cumbersome and not easy to find for others. I proposed to apply Daniel's patch. Then, via "show yrange", I can easily copy the real current range to my script, and edit the range manually. > >>- hidden patches > > > I think these are rock solid. > > The patch on degenerate polygons is a clear cut case. There is simply no way of > choosing a plane direction from 2 points. Such a thin "triangle" shouldn't have > any visual effect anyway. Just discard those and all is fine. >From a user point of view, the patch brings hiding of lines and polygons, which look much better (and correctly) than what we have now. So, it's an improvement, therefore I propose to apply the patch. --- PM |