|
From: Daniel J S. <dan...@ie...> - 2007-06-04 22:10:26
|
Timothée Lecomte wrote: >>>The other day Petr made a change to rid the int_error() function. >>>Rather than >>>putting "Warning:" in the printf, could the int_warn() function be used >>>as in >>>the attached patch instead? >> >>>gnuplot-history/src/history.c >>>- fprintf(stderr, "Warning: cannot open file %s for saving the >>>history.", filename); >>>+ int_warn(NO_CARET, "cannot open file %s for saving the history.", >>>filename); >> >>Yes, it seems to work. >>Is it needed to change it? >> > > > Those two are equivalent.int_warn() with NO_CARET is like fprint(stderr,...) > I personally would keep the fprintf as we immediately see what it's doing. > int_warn is more for cases when user input (i.e. a command line) is involved. I'll go with that logic. Dan |