|
From: <tim...@en...> - 2007-05-23 16:28:48
|
> On Tuesday 22 May 2007 14:47, Timothée Lecomte wrote:
>> Ethan or Hans-Bernhard maybe, I'd appreciate if you wanted to give a
>> quick
>> look at the patch and tell me if this approach (not the details) looks
>> right to you.
>
> The conditional dependencies look suspicious to me.
>
> In wxt_gui.h I see this:
> #if defined(__WXGTK__) || defined(__WXMAC__)
> # define WXT_MULTITHREADED
> #elif defined(__WXMSW__)
> # define WXT_MONOTHREADED
>
> But then in wxt_gui.cpp I see:
>
> #ifdef WXT_MULTITHREADED
> extern "C" int gnu_main(int argc, char **argv);
> int main(int argc, char **argv)
> {
> #ifdef __WXMSW__
> /* the following is done in wxEntry() with wxMSW only */
> wxSetInstance(GetModuleHandle(NULL));
> wxApp::m_nCmdShow = SW_SHOW;
> #endif /*__WXMSW__*/
>
>
> Is it really possible for __WXMSW__ to be defined inside of
> a block marked #ifdef WXT_MULTITHREADED ?
>
> --
> Ethan A Merritt
>
You're right, the previous code did not handle the Windows case.
I've committed the comments and debugging messages changes to CVS, fixed
the code in my local copy to work for Windows too. Attached is the
corresponding patch against current CVS copy.
Thanks.
Timothée |