|
From: Ethan M. <merritt@u.washington.edu> - 2007-05-22 23:08:39
|
On Tuesday 22 May 2007 14:47, Timoth=C3=A9e Lecomte wrote:
> Ethan or Hans-Bernhard maybe, I'd appreciate if you wanted to give a quick
> look at the patch and tell me if this approach (not the details) looks
> right to you.
The conditional dependencies look suspicious to me.
In wxt_gui.h I see this:
#if defined(__WXGTK__) || defined(__WXMAC__)
# define WXT_MULTITHREADED
#elif defined(__WXMSW__)
# define WXT_MONOTHREADED
But then in wxt_gui.cpp I see:
#ifdef WXT_MULTITHREADED
extern "C" int gnu_main(int argc, char **argv);
int main(int argc, char **argv)
{
#ifdef __WXMSW__
/* the following is done in wxEntry() with wxMSW only */
wxSetInstance(GetModuleHandle(NULL));
wxApp::m_nCmdShow =3D SW_SHOW;
#endif /*__WXMSW__*/
Is it really possible for __WXMSW__ to be defined inside of
a block marked #ifdef WXT_MULTITHREADED ?
=2D-=20
Ethan A Merritt
|