Re: [Gnuplot-cvs] CVS Update: gnuplot

[<tim...@en...>]

Hans-Bernhard Br=F6ker wrote:
> Timoth=E9e Lecomte wrote:
>  =20
>> CVSROOT:	/cvsroot/gnuplot
>> Module name:	gnuplot
>> Repository:	./
>> Changes by:	tle...@sc....(none)	06/08/06 19:00=
:56
>>
>> Modified files:
>> 	./: ChangeLog INSTALL configure.in=20
>>
>> Log message:
>> 	Remove detection of libpng, useless since the png driver has been rem=
oved.
>>    =20
>
> Thimo, are you *sure* this is a good idea?  Are you sure there's no=20
> supported platform where libpng has to be searched and found for GD to=20
> compile?
>  =20
I took some time before doing this and I think it's ok. Let me explain :

To compile GD itself, sure, libpng has to be searched for. Not only=20
libpng, but also zlib and libjpeg (note that gnuplot's ./configure=20
doesn't do anything for libjpeg).

Then, the code that I removed was really doing _nothing_.

    libpng_CPPFLAGS was defined but never appended to CPPFLAGS, nor=20
exported for automake.
    libpng_LDFLAGS was defined but never appended to LDFLAGS, nor=20
exported for automake.
    HAVE_LIBPNG was defined but not used anywhere in the code since the=20
standalone png driver has been removed.

There was a step to check for the libpng version, but that's not=20
gnuplot's problem, it gd's problem.

Actually, I'm tempted to remove the test for zlib too, because it's gd's=20
problem too. The only problem when removing that one is when an old=20
version of gd (which doesn't have gdlib-config) is used.

Thanks for asking !

Best regards,

Timoth=E9e