|
From: Ethan M. <merritt@u.washington.edu> - 2006-06-28 16:26:35
|
On Wednesday 28 June 2006 08:07 am, Petr Mikulik wrote: > > I've placed a patch under bug report [ 1004754 ] on SourceForge > > that is a cleanup of the tic generation. I think it would be worth > > considering for 4.2, because it does fix the bug and it is much > > friendlier computer math > > I propose to commit it. > > Notes: "logorithm" => "logarithm" I have not analyzed the code itself, and don't have time to do so right now. But the cover explanation contains an off-by-one error in the algorithm, so I worry that it is not correct. > number of intervals, N_int > /* Address rounding issues in the following way */ > if (i_tic == (N_int - 1)) > tic = end; > else > tic = start + i_tic * step; This is an off-by-one error, an instance of the "fencepost problem". The obvious case is when there is one interval, so (N_int-1) == 0 , and the above code puts both tics at the same end of the axis. > > (I wish also the "rounding" plot [-1:1] patch...) > > --- > PM > > > Using Tomcat but need to do more? Need to support web services, > security? Get stuff done quickly with pre-integrated technology to > make your job easier Download IBM WebSphere Application Server > v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121 >642 _______________________________________________ > gnuplot-beta mailing list > gnu...@li... > https://lists.sourceforge.net/lists/listinfo/gnuplot-beta -- Ethan A Merritt Biomolecular Structure Center University of Washington, Seattle WA |