|
From: <tim...@en...> - 2006-06-03 01:27:51
|
> The only problems I notice are that > (1) You must do a manual replot after resizing the terminal > (else the mouse coords are wrong among other things) > (2) I have to hack the source to make it ignore 'q' > We've got to come up with an equivalent to the ctrlq X-resource In the spirit of the patch for the spacebar, we could bind 'q' to a new mechanism in mouse.c based on the codes for "set <term> close" and the "winid" field in the gp_event_t structure. See below for limitations of this approach. > On a related topic, are you happy with the state of the > "Bind <space> to builtin_raise in mouse.c" patchset? > If so, let's commit it to CVS. *I* am happy with it, but I aknowledge a regression of this approach : th= e events from the terminal have to be processed to be taken into account. For example : set term wxt plot x <press space> =3D> the gnuplot console is raised set term x11 plot x <press space in the wxt window> =3D> nothing happens <press space in the x11 window> =3D> the gnuplot console is raised set term wxt plot x <press space in the x11 window> =3D> nothing happens <press space in the wxt window> =3D> the gnuplot console is raised set term png <press space in the x11 window> =3D> nothing happens <press space in the wxt window> =3D> nothing happens Without the patch, in any case the gnuplot console is raised. If this is acceptable, then the patch should be committed. >> 2) Lars Hecking reported that 'make check' before 'make install' will >> complain (just a warning) because it doesn't find the PNG icons used >> in the toolbar. Indeed they have to be installed in >> PREFIX/share/gnuplot/4.1/png before they can be used. I proposed to >> replace the PNG icons by XPM icons included at compile time. > > I'd rather keep the PNG icons, and think about generalizing the > mechanism so that users can configure their own new buttons and > supply an icon to go with it. The both solutions are not mutually exclusive. The point is that dealing with hard-coded paths is quite a nightmare to make it work in every situation. Timoth=E9e |