Re: wxWidgets terminal commited

[<tim...@en...>]

> Timoth=E9e Lecomte writes:
>> Dear gnuplot developpers,
>>
>> After 11 months of development, the wxWidgets has landed to the CVS ! =
(I
>> hope I did not make any mistake by the way)
>
>  Timoth=E9e,
>
>  I'm trying to repair the build system after this commit.

Thank you for paying attention to this.

> There are two issues:
>
> | dnl Check for object files creation, needed to build these object fil=
es
> in subdirs
> | AM_PROG_CC_C_O
>
>  This is not what AM_PROG_CC_C_O does. It is a wrapper for AC_PROG_CC_C=
_O:
>
> |     If the C compiler does not accept the `-c' and `-o' options
> |     simultaneously, define `NO_MINUS_C_MINUS_O'.  This macro actually
> |     tests both the compiler found by `AC_PROG_CC', and, if different,
> |     the first `cc' in the path.  The test fails if one fails.  This
> |     macro was created for GNU Make to choose the default C compilatio=
n
> |     rule.
>
>  It's not needed. Can I remove it?

Interesting remark. In fact, I can see two alternatives :

* I introduced the automake option 'subdir-objects', so that wxt_gui.o fo=
r
example will be put in src/wxterminal/wxt_gui.o instead of src/wxt_gui.o.
Even if it is not specified clearly in the documentation, with
'subdir-objects', we need this AM_PROG_CC_C_O.

If I remove it on my machine (autoconf 2.59, automake 1.9.6), ./prepare
(or autonconf) fails with the following message :

src/Makefile.am: C objects in subdir but `AM_PROG_CC_C_O' not in
`configure.in'

However, the current code is probably wrong as AM_PROG_CC_C_O should be
checked unconditionnally, since 'subdir-objects' is used unconditionnally.

* There's another option : we can remove both 'subdir-objects' in
src/Makefile.am and AM_PROG_CC_C_O in configure.in
Then, wxt_gui.o and gp_cairo.o will be put in src/ instead of
src/wxterminal/, but I can definitely live with that.

So, what's your preference ?

>  Number two: if no wxWidgets are installed, the result for $WX_CONFIG i=
s
> "no",
>  and configure then tries to run the command "no". I have changed the
> logic.
>
>  if test $WX_CONFIG
>  ...
>  fi
>  if expr 2.3.3 \> `${WX_CONFIG} --version`
>  fi
>
>  to
>
>  if test $WX_CONFIG
>  ...
>  else
>    if expr 2.3.3 \> `${WX_CONFIG} --version`
>    fi
>  fi
>
>  Ok?

Yes, you are right. Thanks for pointing this out !

Timoth=E9e