Re: valgrind

[Daniel J S. <dan...@ie...>]

I've put some comments within to indicate what the line numbers correspond to in my version of the source code:



correlation matrix of the fit parameters:

               c33    c11    c44    c13    phi0
c33             1.000
c11            -0.066  1.000
c44            -0.198 -0.278  1.000
c13            -0.141  0.028 -0.086  1.000
phi0            0.114 -0.022  0.034  0.181  1.000
==9857== Conditional jump or move depends on uninitialised value(s)
==9857==    at 0x8060111: update (fit.c:989)

    tmp = s + strlen(s) - 1;
    while (*tmp != '\\' && *tmp != '/' && *tmp != ':' && tmp - s >= 0)
[989]	tmp--;

[Not sure what valgrind is complaining about.  Maybe the memory pointed to by "s" coming into the routine is not initialized.]


==9857==    by 0x805425E: update_command (command.c:1711)
==9857==    by 0x8055157: do_line (command.c:530)
==9857==    by 0x8088576: load_file (misc.c:277)
==9857==
==9857== Conditional jump or move depends on uninitialised value(s)
==9857==    at 0x8060102: update (fit.c:989)
==9857==    by 0x805425E: update_command (command.c:1711)
==9857==    by 0x8055157: do_line (command.c:530)
==9857==    by 0x8088576: load_file (misc.c:277)
==9857==
==9857== Conditional jump or move depends on uninitialised value(s)
==9857==    at 0x8060106: update (fit.c:989)
==9857==    by 0x805425E: update_command (command.c:1711)
==9857==    by 0x8055157: do_line (command.c:530)
==9857==    by 0x8088576: load_file (misc.c:277)





******************** file world.dem ********************
Hit return to continue
Hit return to continue
Hit return to continue
Hit return to continue
==9857==
==9857== Use of uninitialised value of size 8
==9857==    at 0x8099B95: eval_3dplots (plot3d.c:775)

	    if (j >= 4) {
[775]		color = v[3];
		color_from_column(TRUE);

[My guess would be that v[3] is not set correctly inside datafile.c.]

==9857==    by 0x8055157: do_line (command.c:530)
==9857==    by 0x8088576: load_file (misc.c:277)
==9857==    by 0x8053036: load_command (command.c:978)
Same plot with hidden line removal
==9857==
==9857== Use of uninitialised value of size 8
==9857==    at 0x8099B95: eval_3dplots (plot3d.c:775)
==9857==    by 0x805449F: replotrequest (command.c:1843)
==9857==    by 0x8055157: do_line (command.c:530)
==9857==    by 0x8088576: load_file (misc.c:277)
Hit return to continue
******************** file prob.dem ********************






Now create a x/y datafile for plotting with vectors
and display vectors parallel to the electrostatic field
Hit return to continue


==9857==
==9857== Use of uninitialised value of size 8
==9857==    at 0x807774A: plot_vectors (graphics.c:3272)

	points[0] = plot->points[i];
[3272]	points[1].x = plot->points[i].xhigh;
[3273]	points[1].y = plot->points[i].yhigh;

[A quick search on xhigh and yhigh shows it isn't set very often.  Probably these aren't being set properly when reading in some points.]

==9857==    by 0x807A8A6: do_plot (graphics.c:1760)
==9857==    by 0x80932AD: eval_plots (plot2d.c:2181)
==9857==    by 0x8055157: do_line (command.c:530)
==9857==
==9857== Use of uninitialised value of size 8
==9857==    at 0x807774E: plot_vectors (graphics.c:3273)
==9857==    by 0x807A8A6: do_plot (graphics.c:1760)
==9857==    by 0x80932AD: eval_plots (plot2d.c:2181)
==9857==    by 0x8055157: do_line (command.c:530)
Hit return to continue********************** file tics.dem *********************H