|
From: Daniel J S. <dan...@ie...> - 2006-03-13 07:30:34
|
OK, I've made a fix for the palette allocation problem and placed it on the SourceForge patch page (1448674). This should make us all happier. For reference, the original email was of Jan 7, 2006. Basically, Petr could apply this at any time, but I left it on the patch page for Hans and Ethan to take a run through. I made a complete "copy_at()" in eval.c patterned after "free_at()". Using free_at() as a model should mean no memory is assigned by copy_at() that won't be deleted by free_at(). So, take a look at that. Also, in getcolor.c are a couple routines copy_udft() clear_udft() Although they are conceptually similar to copy_at() and free_at(), I figured they really aren't as portable so avoided bloating things too much. (Note copy_udft() and clear_udft() only get included in the core gnuplot routine, not gplt_x11.) Dan Petr Mikulik wrote: >> Here's a patch for that gnuplot "allocating colors..." redraw problem >> with rotation. The princple is as follows: > > > It looks OK. I passed "pm3dcolors.dem" on it (with "set pm3d map" => > "set pm3d"), rotated by mouse, it's no more reallocating colors and no > strange thing happened. > > BTW, I prefer to surround unused code by #if 0 #endif instead of /** > */; it's more readable. > >> OK, so that's one problem down and two to go. I'll see if I can get >> to another one next weekend. > > > Please resend the patch when it's final for cvs. > |