Re: Argh: Why are arrows clipped to the graph?

[Ethan M. <merritt@u.washington.edu>]

On Wednesday 09 November 2005 03:10 pm, Harald Harders wrote:
> On Wed, 9 Nov 2005, Ethan Merritt wrote:
> 
> > On Wednesday 09 November 2005 02:32 pm, Harald Harders wrote:
> > >
> > > I once have provided a patch that worked, storing both the term boundaries
> > > as they are now and the canvas size. It wasn't applied to cvs. I remember
> > > that you were one of the people that complained that this was not the
> > > right way to do it. But it worked.
> >
> > I do not recall seeing such a patch.
> > Could you remind me which one that is?
> > I don't see anything on SourceForge that seems to match your description.
> 
> #1104264, Fix buggy clipping of arrows in large splots
> #1105611, Introduce 'set pagesize' command
> 
> > > term->xmax means the position, where the screen coordinate is 1
> > > term->ymax means the position, where the screen coordinate is 1
> > > term->xcanvas is the maximal screen coordinate in the canvas
> > > term->ycanvas is the second maximal screen coordinate in the canvas
> > >
> > > This has been provided by my rejected patch, to remind you once again.

Err, that feature is not found in either of the patches you mentioned.

The "Fix buggy clipping" patch does not touch any terminal drivers.

The "set pagesize" patch introduces a pair of global scaled values
xpagesize and ypagesize, but does not add anything like
term->canvas_xmin,
term->canvas_xmax,
term->canvas_ymin,
term->canvas_ymax
which is what you would need in order to do clipping.

Although at this point I would prefer to add something like
(BoundingBox *)(term->canvas)
I.e., a structure containing all of the above that could be
passed directly to the clipping routines as a pointer.


-- 
Ethan A Merritt       merritt@u.washington.edu
Biomolecular Structure Center
Mailstop 357742
University of Washington, Seattle, WA 98195