Re: [Bug #1264105] In currrent CVS version plotting matrix is broken

[Ethan A M. <merritt@u.washington.edu>]

On Saturday 22 October 2005 03:02 pm, Petr Mikulik wrote:
> I think I've tracked the bug down

Found it. Bleah. It really has been there since forever.
It's in df_tokenise(), and it is specific to ascii matrix data.
Here is the fix:

--- gnuplot/src/datafile.c      2005-10-21 22:50:13.000000000 -0700
+++ gnuplot-cvs/src/datafile.c  2005-10-22 21:10:08.276728128 -0700
@@ -1145,6 +1146,7 @@
             if (df_matrix) { duplication=TRUE; break; }
             df_matrix = TRUE;
 #endif
+           fast_columns = 0;
             continue;
     }

Corey Satten's monster optimization test skips all columns past the
first three unless some test has previously cleared the fast_columns
flag.  Examples of things that clear the flag are parentheses in the
using spec and the presence of the "binary" flag. The optimization
test is also skipped if there are no using specs at all.
Ascii matrix data is not covered by any of these exceptions, so
df_tokenise() only parses the first 3 columns.

Amazing that no one has complained in all the time since 3.7 came
out.

-- 
Ethan A Merritt
Biomolecular Structure Center
University of Washington, Seattle 98195-7742