Ethans patch of 2005-10-15

[Harald H. <h.h...@tu...>]

I do not really understand what the aim of Ethans patch of 2005-10-15 is.
It introduces a new structure type which can take bounds of plots and the
canvas. This is good.

But I still do not understand what it does. Because the variable canvas is
a pure copy of  { 0, term->xmax, 0, term->ymax }. Why do we now have the
term->xmax and term->ymax and a copy of them? What does it really do?

Still, the clipping of
labels and arrow does not work at all.

Try this:

set size 2,2
set term png size 320,240
set arrow from screen 0.9,0.5 rto screen 0.2,0.0
set arrow from screen 1.1,0.7 rto screen -0.2,0.0
set output 'asdf.png'
splot sin(x)*cos(y)
quit

What we get is a plot that only contains labels below screen 1,1 and
arrows that start below screen 1,1. So, what was the aim of the patch?

What we need is to set the canvas boundaries at 'set terminal' (and not
in term_start_plot()) to

canvas.xright = term->xmax * xsize;
canvas.ytop = term->ymax * ysize;

In addition, the clipping routines, e.g. on_page, get_arrow3d, have to use
canvas.xright and canvas.ytop.

I have provided a patch that has been working before this new change in
CVS, and I will not provide a new one.

We will have to fix the old system (enabling sizes > 1) before we
can even think of changing it.

Ethan, why have you put your patch to cvs without discussing it in the
mailing list?

Regards
Harald

-- 
Harald Harders
h.h...@tu...
http://www.harald-harders.de