Re: Patch for RFE [ 992352 ] [Win32] console backlog length is hardwired

[Robert H. <en...@no...>]

On Wed, 2005-10-05 at 14:42 +0200, Bastian Maerkisch wrote:
> Hi,
> 
> this patch adds two new settings to wgnuplot.ini:
> `BacklogLength` and `BacklogWidth`. This way a user can
> adjust the length and width of the internal backlog
> buffers accordings to his personal preferences.
> 
> Bastian
> 
> plain text document attachment (win_backlog-20051005.patch)
> diff -ur gnuplot/src/win/wtext.c gnuplot-current/src/win/wtext.c
> --- gnuplot/src/win/wtext.c	2004-07-07 18:56:08.000000000 +0200
> +++ gnuplot-current/src/win/wtext.c	2005-10-05 14:06:48.063228500 +0200
> @@ -323,6 +323,10 @@
>      WritePrivateProfileString(section, "TextFont", profile, file);
>      wsprintf(profile, "%d", lptw->bSysColors);
>      WritePrivateProfileString(section, "SysColors", profile, file);
> +    wsprintf(profile, "%d", lptw->ScreenSize.x);
> +    WritePrivateProfileString(section, "BacklogWidth", profile, file);
> +    wsprintf(profile, "%d", lptw->ScreenSize.x);

Shouldn't one of these by ScreenSize.y?

> +    WritePrivateProfileString(section, "BacklogLines", profile, file);
>      if (iconic)
>  	ShowWindow(lptw->hWndParent, SW_SHOWMINIMIZED);
>      return;
> @@ -382,6 +386,11 @@
>      GetPrivateProfileString(section, "SysColors", "", profile, 80, file);
>      if ((p = GetInt(profile, &lptw->bSysColors)) == NULL)
>  	lptw->bSysColors = 0;
> +
> +    if (bOKINI) {
> +	lptw->ScreenSize.x = GetPrivateProfileInt(section, "BacklogWidth", 80, file);
> +	lptw->ScreenSize.y = GetPrivateProfileInt(section, "BacklogLines", 80, file);

Did you mean 500 here?

> +    }
>  }
>  
> 
> --- gnuplot/term/win.trm	2005-08-09 11:07:02.000000000 +0200
> +++ gnuplot-current/term/win.trm	2005-10-05 14:28:23.571548500 +0200
> @@ -609,7 +609,10 @@
>  "       [WGNUPLOT]",
>  "       TextOrigin=0 0",
>  "       TextSize=640 150",
> -"       TextFont=Terminal,9",
> +"       TextFont=Terminal,9",
> +"	SysColors=1",
> +"	BacklogWidth=80",
> +"	BacklogLines=500",

Or did you mean 80 here?

I think there's a tabs vs. spaces thing going on here. Not sure what
format is preferred, but I'd go with the existing file format.

>  "       GraphOrigin=0 150",
>  "       GraphSize=640 330",
>  "       GraphFont=Arial,10",
> @@ -632,7 +635,9 @@
>  " solid line in color mode, or a dashed line in monochrome mode.  The default",
>  " line width is 1 pixel.  If `Linestyle` is negative, it specifies the width of",
>  " a SOLID line in pixels.  Line1 and any linestyle used with the `points` style",
> -" must be SOLID with unit width.",
> +" must be SOLID with unit width.",
> +" `BacklogWidth` and `BacklogLength` specify the size of the initernal backlog"
> +" of the windows terminal window."

What is the current "hardwired" value, and what is the problem with it?
Would it be possible to come up with a better default? Also what happens
with very large values? Don't you have a 16k limit on the buffer size in
win16? That's only 200 80-character lines.

-- 
Robert Hart <en...@no...>
University of Nottingham


This message has been checked for viruses but the contents of an attachment
may still contain software viruses, which could damage your computer system:
you are advised to perform your own checks. Email communications with the
University of Nottingham may be monitored as permitted by UK legislation.