Re: wxWidgets terminal grows up

[<tim...@en...>]

Ethan A Merritt wrote:

>On Saturday 24 September 2005 02:14 pm, Timoth=E9e Lecomte wrote:
> =20
>
>>I have just sent a new patch which implements a wxwidgets terminal for
>>gnuplot.
>>Hope you will have fun with this release, and thanks for your interest.
>>   =20
>>
>I'm just trying this out for the first time.
>I'll type in my thoughts as I go....
> =20
>
Thanks for testing it !

>- Configures and builds with no problem.
>
>- Unfortunately, the x11 terminal doesn't work unless I "unset mouse".
>  Something in the new code must conflict with the x11 mousing protocol.
> =20
>
Ok I read your next mail and I feel better now as it's not my fault ;-)

>- "set term wx" works
>
>- "test" looks good, except:
>	+ polygon is not colored
> =20
>
I know it, but have not digged much to know where it comes from. The
command _set_color() does its job quite well for a pm3d plot, but
doesn't seem to be called in "test". Maybe _linetype should also affect
polygon color.

>	+ rotated text is illegible
> =20
>
Could you provide a screenshot ? On my box I find it far more legible
than the way x11 renders it. Make your own opinion here :

http://tipote.free.fr/wxt4.png (taken some weeks ago, but rotated text
didn't changed)
http://tipote.free.fr/x11-1.png

>	+ text width is not accurately estimated
> =20
>
It's true, and I don't understand yet why. The string I use to test font
width is exactly the one drawn here : 12345678901234567890

>	+ Point styles 6 + 7 really should be an open and closed
>	  circle, respectively
> =20
>
Points are drawn thanks to the generic do_point() provided by gnuplot.
Do I lack something else ?
The term/README says it is enough, but obviously it doesn't draw filled
symbols.

>- "simple.dem" looks good
> =20
>
Ok.

>- "rgb_variable.dem"
>	+ Cannot rotate 3D plot using mouse or cursor keys while
>	  the main program is in "pause -1"
>
You're right. The main thread is waiting for input from the user, and doe=
sn't process gui events sent by the terminal. I need to rework it.

>	+ Requested point style (filled circle) not available
> =20
>
It's related to "test" above.

>	+ Text and points are not colored.
> =20
>
Indeed, I should look at it.

>- after "Control-C" to return control to the main terminal window,
>  it's dead.
>	+ Full terminal reset doesn't help
>	+ Closing the wxterm window doesn't help
>	+ Control-Z doesn't work
>	+ I had to issue "kill -9" from another window in order to
>	  recover use of the original terminal session
> =20
>
I also faced a case where hitting "ctrl-c" makes me lose keyboard input
in the gnuplot command line, and "kill [gnuplot pid]" closes gnuplot
cleanly. Maybe ctrl-c means somethings particular for the wxwidgets
toolkit. I will note it in my bug list !

>- "surface1.dem"
>	+ looks good, but still cannot rotate the plot interactively
>	+ PM3D surface looks good
>	+ the very last plot of the demo looks fine to begin with
>	+ now that control has returned to the main window I can rotate
>	  interactively, but as soon as I do the plotted figure degrades
>	  to some low-resolution grid.  I can't think what would cause this.
> =20
>
'surface1.dem' ends with 'reset', which seems to reset isosamples to its
default value. If you hit 'set isosamples 60' you'll get back the full
resolution plot. The same happens with the x11 terminal.

>- "surface2.dem"
>	+ looks fine up to the last plot, but if I hit "Ctrl-C" at that
>	  point the program segfaults
> =20
>
Indeed, I also get glibc errors when hitting ctrl-c... Strange...

>- "rainbow.dem"
>	+ The lines are colored, but the colors are wrong. Looks like
>	  explicit color settings are ignored
> =20
>
Right. It uses linetype colors. Will fix it.

>- "polar.dem"
>	+ Oops, I forgot to say "reset". Hit control-C to return to command
>	  line.  Terminal is dead again, and session has to be externally
>	  "kill -9"ed.  This is an annoying bug.
> =20
>
Ok, I face exactly the same bug.

>	+ Start again. Works fine.
>
>- "enhancedtext.dem"
>	+ Works nicely except that it doesn't find a Symbol font.
>	  How/where does the wx terminal find its fonts?
> =20
>
In fact, at least on my box, it finds the Symbol font, but refuses to
show characters > 127, as I get "mu" and "pi" correctly drawn but not
"infinite" and "sum". I think it's a wxwidgets bug, as the wxwidgets
font sample has the same problem. The recent 2.6.2 release contains a
line about fonts and gtk on its changelog, so it may have been solved,
but I have not tested yet.

>- "fillstyle.dem"
>	+ Uh oh. Problems here. Aside from the fact that the boxes are
>	  all black, the lower bound of each rectangle is incorrect.
>	  The must be a bug or two in the fillbox and/or filled_polygon
>	  driver routines.
> =20
>
I saw it but completely forgot to fix it. It comes from some changes
regarding the way I handle coordinates between gnuplot and wxwidgets.

>- "test"
>	+ Hey! This time I get a red polygon. It was black before.
>	  (It's supposed to be blue :-).  Repeated trials turn up pink
>	  and purple, also.  Random colors?
> =20
>
Not random ;-) probably based on the last _set_color() call in a
previous plot...

>- "image.dem"
>	+ OK
>
>- "set term wxt 2"
>	+ I thought maybe I could get a second window. But no, instead the
>	  program hangs.
> =20
>
I have not implemented it yet. However, the program does not hang for
me, but just gives 'unrecognized terminal option'.

>General comments:
>
>- Looks very promising.=20
>
>- The incompatibility with x11 is obviously a problem, but I assume it's
>  fixable.
>
And you've fixed it ;-)

>The failure to handle control-C properly is quite annoying, as
>  is the inability to rotate 3D plots while in a "pause" command.
> =20
>
Right, those are really problems. I will try to isolate the problems.

>- The "zoom" and "unzoom" icons are totally non-intuitive, at least to
>  me.  They look like the "cancel last edit" and "redo last edit" icons
>  from some word processing programs.
>
I admit this. Maybe it could be more intuitive with comprehensive zoom
icons. In all cases I will rework those with a magnifier.

>Also the clipboard icon looks like
>  a "new document" icon - how about using a little clipboard?
> =20
>
In fact, the 'two pages' icon is the standard for 'copy', and the one
with a clipboard is often used for 'paste', but as we only have one of
these, the second one is clearer.

>- What are the possibilities for multiple plot windows?
>
In my opinion, it's just a matter of coding ;-) but there is no
limitation from wxwidgets.

I'm really pleased that you tried it and took the time to report me all
these problems. I will try to fix them, and to implement things that are
lacking.

Regards,

Timoth=E9e Lecomte