Incorrent conditional code for X11_BINARY_POLYGON

[Ethan M. <merritt@u.washington.edu>]

Daniel:

The #ifdef / #else / #endif blocks in gplt_x11.c are
horribly unreadable.  So much so that they have hidden
some serious mis-ordering of the statements.


Try
  ./configure --with-image --disable-binary-x11-polygon
  cd src
  make gnuplot_x11

and watch everything fall apart.

The nested #ifdef/#endif code blocks that end just before
line 3050 of gplt_x11.c are clearly incorrect, but I cannot
see what the original intent was.

Can you please try to clean up this code?
I suggest that no #ifdef/#endif pair should leave unbalanced
curly brackets in the code.  This sort of thing:

if (A) {
#ifdef FOO
    if (B)
	{
	blah; blah;
#else
   yadda; yadda;
#endif


is just asking for trouble.
 

-- 
Ethan A Merritt       merritt@u.washington.edu
Biomolecular Structure Center
Mailstop 357742
University of Washington, Seattle, WA 98195