Re: Bug in image code ?

[Hans-Bernhard B. <br...@ph...>]

Ga=EBl Varoquaux wrote:

>     I don't see any obvious difference, but I think I have missed your
> point. I don't really understand where axis_array[axis].term_lower come=
s
> from, and what it is supposed to be.

It's the lower border of the graph box, in terminal coordinates.  In=20
other words, for axis=3DFIRST_Y_AXIS, this is where the x axis will be (i=
n=20
a 2D plot).  It must be non-negative, and smaller than term->ymax.=20
Similarly, axis_array[FIRST_X_AXIS].term_lower is the position of the y=20
axis, and must be between zero and term->xmax - 1, inclusive.

The values of these variables are computed in graphics.c:boundary() and=20
graph3d.c:boundary3d(), respectively, and used heavily by macros and=20
functions in the 'axis' module, like AXIS_MAP(), and its callers map_x() =

and map_y().

Signed vs. unsigned issues plague the gnuplot source quite a bit.  It's=20
so bad that I've long since given up trying to enable gcc's=20
-Wsign-compare even in my "picky mode" CFLAGS.  You have to tread=20
carefully there.  And try to remember that we have at least some drivers =

where

	INT_MAX < term->xmax < UINT_MAX.

so no, casting isn't generally going to help.