|
From: Daniel J S. <dan...@ie...> - 2007-01-16 03:48:30
|
I've placed a patch on SourceForge that changes the option name of 'hidden3d' to 'tileline' of 'set pm3d'. Then hidden3d is enabled to work with 'with pm3d' by moving the hidden line function call to after the pm3d code in 'graph3d.c'. Also, documentation makes the distinction between the two. Please consider making this change. It's a relatively short patch. I think it more accurately reflects the plotting action. (It takes a while for someone to realize that 'hidden3d' for 'set pm3d' and the 'set hidden3d' are actually two different things.) It also moves things in the direction that Ethan suggested. Future work would be to integrate solid surfaces into the hidden code. The first example of 'transparent_solids.dem' I've left as is. The second example (Kuen) I've changed to use the hidden3d. I realize that messes up the intended illustration of transparent surfaces. After the patch, someone can rearrange the demos. (I'd suggest using Kuen surface as an example of illustrating speed and bad tile order in pm3d.dem... see my comments below about the current illustrations in pm3d.dem.) Dan ... Petr, in the demo 'pm3d.dem' it says set title "surface at view 130,10 (viewed from below)" set pm3d set palette set view 130,10 set samples 50; set isosamples 50 set border 4095 unset surface set pm3d at s scansforward splot sin(sqrt(x**2+y**2))/sqrt(x**2+y**2) pause -1 "Hit return to continue" This example isn't technically something that looks to be view from below, is it? Instead there is something discontinuous about it. Also, the above plot and the one that follows it: set title '"set pm3d scansbackward" makes this as viewed from above' have border lines that appear kind of Escher-ish. A little further along in the demo is the plot: set title "set hidden3d" set samples 30; set isosamples 30 set hidden3d set pm3d set surface set view 50,220 set xrange [-2:2] set yrange [-2:2] splot log(x*x*y*y) Notice, that prior to the patch I created, this plot did not have hidden3d present. After the patch, it looks to have hidden3d, per the plot description. |
|
From: Daniel J S. <dan...@ie...> - 2007-01-16 06:20:30
|
Daniel J Sebald wrote: > I've placed a patch on SourceForge that changes the option name of > 'hidden3d' to 'tileline' of 'set pm3d'. Or maybe "outline" would suffice as opposed to "tileline" Dan |
|
From: Daniel J S. <dan...@ie...> - 2007-01-16 08:22:39
|
Daniel J Sebald wrote: > Daniel J Sebald wrote: > >>I've placed a patch on SourceForge that changes the option name of >>'hidden3d' to 'tileline' of 'set pm3d'. > > > Or maybe "outline" would suffice as opposed to "tileline" Oh yeah, I forgot to mentioned that from my tests it looks like the slowness of the double torus example in 'transparent_solid.dem' is due more to drawing all those elements in gnuplot_x11. Dan |
|
From: Petr M. <mi...@ph...> - 2007-01-16 13:41:51
|
> Please consider making this change. It's a relatively short patch. Unfortunately it does not patch to current cvs. > >Or maybe "outline" would suffice as opposed to "tileline" > I would find "sort3d" more intuitive. Perhaps you were looking for a more > encompassing name reflecting the overall effect of "estimate hidden line > removal". But in some sense, "depthorder" or "sort3d" is specific too > because the user needs to understand that the pm3d elements are what are > being sorted. So "outline" is no more specific than "depthorder". Yes, sorry, I thought you want to replace "depthorder". > Petr, in the demo 'pm3d.dem' it says > set title "surface at view 130,10 (viewed from below)" > set pm3d > set palette > set view 130,10 > set samples 50; set isosamples 50 > set border 4095 > unset surface > set pm3d at s scansforward > splot sin(sqrt(x**2+y**2))/sqrt(x**2+y**2) > pause -1 "Hit return to continue" > > This example isn't technically something that looks to be view from below, is > it? Instead there is something discontinuous about it. > > Also, the above plot and the one that follows it: > > set title '"set pm3d scansbackward" makes this as viewed from above' > > have border lines that appear kind of Escher-ish. The plot depends on the scan direction. Shown are those rectangles coming last. It is probably the plot title which should change. --- PM |
|
From: Daniel J S. <dan...@ie...> - 2007-01-16 20:46:13
|
Petr Mikulik wrote: >>Please consider making this change. It's a relatively short patch. > > > Unfortunately it does not patch to current cvs. It works for the CVS version I downloaded half an hour ago. >>Also, the above plot and the one that follows it: >> >>set title '"set pm3d scansbackward" makes this as viewed from above' >> >>have border lines that appear kind of Escher-ish. > > > The plot depends on the scan direction. Shown are those rectangles coming > last. It is probably the plot title which should change. Yes, title change is what is needed. Dan |
|
From: Petr M. <mi...@ph...> - 2007-01-16 08:23:51
|
> > I've placed a patch on SourceForge that changes the option name of > > 'hidden3d' to 'tileline' of 'set pm3d'. > > Or maybe "outline" would suffice as opposed to "tileline" I would find "sort3d" more intuitive. --- PM |
|
From: Daniel J S. <dan...@ie...> - 2007-01-16 08:33:03
|
Petr Mikulik wrote: >>>I've placed a patch on SourceForge that changes the option name of >>>'hidden3d' to 'tileline' of 'set pm3d'. >> >>Or maybe "outline" would suffice as opposed to "tileline" > > > I would find "sort3d" more intuitive. "sort3d", for the option of including a line drawn around the pm3d elements? I guess I didn't write that out correctly. What I was proposing would be set pm3d depthorder outline rather than set pm3d depthorder hidden3d Were you thinking I meant a different name for "depthorder" or something else? Dan |
|
From: Daniel J S. <dan...@ie...> - 2007-01-16 08:45:12
|
Petr Mikulik wrote: >>>I've placed a patch on SourceForge that changes the option name of >>>'hidden3d' to 'tileline' of 'set pm3d'. >> >>Or maybe "outline" would suffice as opposed to "tileline" > > > I would find "sort3d" more intuitive. Perhaps you were looking for a more encompassing name reflecting the overall effect of "estimate hidden line removal". But in some sense, "depthorder" or "sort3d" is specific too because the user needs to understand that the pm3d elements are what are being sorted. So "outline" is no more specific than "depthorder". Dan |
|
From: Ethan A M. <merritt@u.washington.edu> - 2006-07-18 05:26:10
|
On Monday 17 July 2006 10:23 pm, Daniel J Sebald wrote: > When running histograms.dem the line: > of plot2d.c prints out > Should that fprintf be active for the 4.2 release? No. My bad. That was a debugging statement that escaped out into the wild. > For the history readline, the Home key places an "OH" in the line > and the End key places an "OF" in the command line. > Could those be altered so that Home moves the cursor to the front > and End to the end of the line? It already does that for me, with gnu readline. Are you talking about the built-in readline? -- Ethan A Merritt Biomolecular Structure Center University of Washington, Seattle 98195-7742 |
|
From: Daniel J S. <dan...@ie...> - 2006-07-18 05:33:28
|
Ethan A Merritt wrote: >>For the history readline, the Home key places an "OH" in the line >>and the End key places an "OF" in the command line. >>Could those be altered so that Home moves the cursor to the front >>and End to the end of the line? > > > It already does that for me, with gnu readline. > Are you talking about the built-in readline? Ummm... Yes, I think so. I assume the command line in my xterm is gnu readline because that is how Home/End work there. This is the version that was reactivate one or two months ago. Here is something else. No need to change this, but in gplt_x11.c there is the function DrawRotated(plot_struct *plot, Display *dpy, GC gc, int xdest, int ydest, which defines a variable "gc", but there is also a global variable "gc". Not a problem, but a programmer could get fooled by that. Maybe add a variable rename to the Post-4.2 list. Dan |
|
From: Ethan A M. <merritt@u.washington.edu> - 2006-07-18 05:46:16
|
On Monday 17 July 2006 10:42 pm, Daniel J Sebald wrote: > Here is something else. No need to change this, but in gplt_x11.c there = is the function > DrawRotated(plot_struct *plot, Display *dpy, GC gc, int xdest, int ydes= t, > which defines a variable "gc", but there is also a global variable "gc". If you turn on -Wshadow you'll see a whole lot more than just that one. graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here bitmap.c:86: warning: declaration of =E2=80=98y1=E2=80=99 shadows a global = declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here bitmap.c:1005: warning: declaration of =E2=80=98y1=E2=80=99 shadows a globa= l declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here pm3d.h:149: warning: declaration of =E2=80=98plot_mode=E2=80=99 shadows a g= lobal declaration mouse.h:190: warning: shadowed declaration is here color.c:405: warning: declaration of =E2=80=98y1=E2=80=99 shadows a global = declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here color.c:484: warning: declaration of =E2=80=98plot_mode=E2=80=99 shadows a = global declaration mouse.h:190: warning: shadowed declaration is here color.c:516: warning: pointer targets in passing argument 2 of =E2=80=98map= 3d_position_r=E2=80=99 differ in signedness color.c:516: warning: pointer targets in passing argument 3 of =E2=80=98map= 3d_position_r=E2=80=99 differ in signedness graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here contour.c:282: warning: declaration of =E2=80=98index=E2=80=99 shadows a gl= obal declaration /usr/include/string.h:304: warning: shadowed declaration is here contour.c:1178: warning: declaration of =E2=80=98y0=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:241: warning: shadowed declaration is here contour.c:1178: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here datafile.c:189: warning: declaration of =E2=80=98df_datum=E2=80=99 shadows = a global declaration datafile.h:77: warning: shadowed declaration is here datafile.c:867: warning: declaration of =E2=80=98index=E2=80=99 shadows a g= lobal declaration /usr/include/string.h:304: warning: shadowed declaration is here datafile.c:1951: warning: declaration of =E2=80=98s=E2=80=99 shadows a prev= ious local datafile.c:1662: warning: shadowed declaration is here datafile.c:2337: warning: declaration of =E2=80=98matrix=E2=80=99 shadows a= global declaration binary.h:47: warning: shadowed declaration is here datafile.c:2354: warning: declaration of =E2=80=98index=E2=80=99 shadows a = global declaration /usr/include/string.h:304: warning: shadowed declaration is here datafile.c:2698: warning: declaration of =E2=80=98df_datum=E2=80=99 shadows= a global declaration datafile.c:209: warning: shadowed declaration is here datafile.c:3269: warning: declaration of =E2=80=98i=E2=80=99 shadows a prev= ious local datafile.c:3218: warning: shadowed declaration is here datafile.c:4118: warning: declaration of =E2=80=98dval=E2=80=99 shadows a p= revious local datafile.c:3945: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here fit.c:183: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:185: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:187: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:190: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:191: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:193: warning: declaration of =E2=80=98log_f=E2=80=99 shadows a global= declaration fit.c:161: warning: shadowed declaration is here fit.c:314: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:425: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:451: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:574: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:822: warning: declaration of =E2=80=98a=E2=80=99 shadows a global dec= laration fit.c:165: warning: shadowed declaration is here fit.c:1181: warning: declaration of =E2=80=98log_f=E2=80=99 shadows a globa= l declaration fit.c:161: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here gadgets.c:216: warning: declaration of =E2=80=98y1=E2=80=99 shadows a globa= l declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here gadgets.c:291: warning: declaration of =E2=80=98y1=E2=80=99 shadows a globa= l declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here graph3d.c:2288: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graph3d.c:2293: warning: declaration of =E2=80=98v1=E2=80=99 shadows a prev= ious local graph3d.c:2259: warning: shadowed declaration is here graph3d.c:2381: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graph3d.c:2384: warning: declaration of =E2=80=98angle=E2=80=99 shadows a g= lobal declaration eval.h:140: warning: shadowed declaration is here graph3d.c:2388: warning: declaration of =E2=80=98v1=E2=80=99 shadows a prev= ious local graph3d.c:2356: warning: shadowed declaration is here graph3d.c:2606: warning: declaration of =E2=80=98angle=E2=80=99 shadows a g= lobal declaration eval.h:140: warning: shadowed declaration is here graph3d.c:2683: warning: declaration of =E2=80=98angle=E2=80=99 shadows a g= lobal declaration eval.h:140: warning: shadowed declaration is here graph3d.c:2756: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graph3d.c:3146: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here graphics.c:127: warning: declaration of =E2=80=98exit=E2=80=99 shadows a gl= obal declaration /usr/include/stdlib.h:640: warning: shadowed declaration is here graphics.c:147: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.c:165: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.c:1350: warning: declaration of =E2=80=98clip_area=E2=80=99 shadow= s a global declaration gadgets.h:299: warning: shadowed declaration is here graphics.c:1354: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glo= bal declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.c:2464: warning: declaration of =E2=80=98exit=E2=80=99 shadows a g= lobal declaration /usr/include/stdlib.h:640: warning: shadowed declaration is here graphics.c:2787: warning: declaration of =E2=80=98yn=E2=80=99 shadows a glo= bal declaration /usr/include/bits/mathcalls.h:243: warning: shadowed declaration is here graphics.c:2860: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glo= bal declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.c:2993: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glo= bal declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.c:3533: warning: declaration of =E2=80=98y1=E2=80=99 shadows a glo= bal declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here graphics.c:3781: warning: declaration of =E2=80=98x=E2=80=99 shadows a prev= ious local graphics.c:3680: warning: shadowed declaration is here graphics.c:4474: warning: declaration of =E2=80=98x=E2=80=99 shadows a prev= ious local graphics.c:4467: warning: shadowed declaration is here graphics.c:4562: warning: declaration of =E2=80=98y=E2=80=99 shadows a prev= ious local graphics.c:4555: warning: shadowed declaration is here graphics.c:4857: warning: declaration of =E2=80=98title=E2=80=99 shadows a = global declaration gadgets.h:326: warning: shadowed declaration is here graphics.c:4920: warning: declaration of =E2=80=98title=E2=80=99 shadows a = global declaration gadgets.h:326: warning: shadowed declaration is here hidden3d.c:772: warning: declaration of =E2=80=98v=E2=80=99 shadows a previ= ous local hidden3d.c:695: warning: shadowed declaration is here hidden3d.c:773: warning: declaration of =E2=80=98v=E2=80=99 shadows a previ= ous local hidden3d.c:695: warning: shadowed declaration is here hidden3d.c:774: warning: declaration of =E2=80=98v=E2=80=99 shadows a previ= ous local hidden3d.c:695: warning: shadowed declaration is here hidden3d.c:775: warning: declaration of =E2=80=98v=E2=80=99 shadows a previ= ous local hidden3d.c:695: warning: shadowed declaration is here hidden3d.c:776: warning: declaration of =E2=80=98v=E2=80=99 shadows a previ= ous local hidden3d.c:695: warning: shadowed declaration is here hidden3d.c:777: warning: declaration of =E2=80=98v=E2=80=99 shadows a previ= ous local hidden3d.c:695: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here interpol.c:820: warning: declaration of =E2=80=98x_axis=E2=80=99 shadows a = global declaration axis.h:309: warning: shadowed declaration is here interpol.c:821: warning: declaration of =E2=80=98y_axis=E2=80=99 shadows a = global declaration axis.h:309: warning: shadowed declaration is here matrix.c:137: warning: declaration of =E2=80=98gamma=E2=80=99 shadows a glo= bal declaration /usr/include/bits/mathcalls.h:265: warning: shadowed declaration is here matrix.c:313: warning: declaration of =E2=80=98temp=E2=80=99 shadows a prev= ious local matrix.c:278: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here color.h:253: warning: declaration of =E2=80=98plot_mode=E2=80=99 shadows a = global declaration mouse.h:190: warning: shadowed declaration is here pm3d.h:149: warning: declaration of =E2=80=98plot_mode=E2=80=99 shadows a g= lobal declaration mouse.h:190: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here mouse.c:1478: warning: declaration of =E2=80=98real_x=E2=80=99 shadows a gl= obal declaration mouse.c:126: warning: shadowed declaration is here mouse.c:1478: warning: declaration of =E2=80=98real_y=E2=80=99 shadows a gl= obal declaration mouse.c:126: warning: shadowed declaration is here mouse.c:1478: warning: declaration of =E2=80=98real_x2=E2=80=99 shadows a g= lobal declaration mouse.c:126: warning: shadowed declaration is here mouse.c:1478: warning: declaration of =E2=80=98real_y2=E2=80=99 shadows a g= lobal declaration mouse.c:126: warning: shadowed declaration is here mouse.c:1774: warning: declaration of =E2=80=98real_x=E2=80=99 shadows a gl= obal declaration mouse.c:126: warning: shadowed declaration is here mouse.c:1774: warning: declaration of =E2=80=98real_y=E2=80=99 shadows a gl= obal declaration mouse.c:126: warning: shadowed declaration is here mouse.c:1774: warning: declaration of =E2=80=98real_x2=E2=80=99 shadows a g= lobal declaration mouse.c:126: warning: shadowed declaration is here mouse.c:1774: warning: declaration of =E2=80=98real_y2=E2=80=99 shadows a g= lobal declaration mouse.c:126: warning: shadowed declaration is here mouse.c:2459: warning: declaration of =E2=80=98button=E2=80=99 shadows a gl= obal declaration mouse.c:138: warning: shadowed declaration is here color.h:253: warning: declaration of =E2=80=98plot_mode=E2=80=99 shadows a = global declaration mouse.h:190: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here plot2d.c:71: warning: declaration of =E2=80=98first_plot=E2=80=99 shadows a= global declaration plot2d.h:44: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here plot3d.c:1001: warning: declaration of =E2=80=98point=E2=80=99 shadows a pr= evious local plot3d.c:954: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here pm3d.c:229: warning: declaration of =E2=80=98i=E2=80=99 shadows a previous = local pm3d.c:210: warning: shadowed declaration is here pm3d.c:720: warning: declaration of =E2=80=98j1=E2=80=99 shadows a global d= eclaration /usr/include/bits/mathcalls.h:239: warning: shadowed declaration is here color.h:253: warning: declaration of =E2=80=98plot_mode=E2=80=99 shadows a = global declaration mouse.h:190: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here pm3d.h:149: warning: declaration of =E2=80=98plot_mode=E2=80=99 shadows a g= lobal declaration mouse.h:190: warning: shadowed declaration is here set.c:2309: warning: pointer targets in passing argument 2 of =E2=80=98map_= position=E2=80=99 differ in signedness set.c:2309: warning: pointer targets in passing argument 3 of =E2=80=98map_= position=E2=80=99 differ in signedness set.c:2886: warning: declaration of =E2=80=98a=E2=80=99 shadows a previous = local set.c:2792: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here pm3d.h:149: warning: declaration of =E2=80=98plot_mode=E2=80=99 shadows a g= lobal declaration mouse.h:190: warning: shadowed declaration is here show.c:1988: warning: declaration of =E2=80=98gray=E2=80=99 shadows a previ= ous local show.c:1962: warning: shadowed declaration is here specfun.c:1092: warning: declaration of =E2=80=98y0=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:241: warning: shadowed declaration is here specfun.c:1822: warning: declaration of =E2=80=98y0=E2=80=99 shadows a glob= al declaration /usr/include/bits/mathcalls.h:241: warning: shadowed declaration is here graphics.h:113: warning: declaration of =E2=80=98title=E2=80=99 shadows a g= lobal declaration gadgets.h:326: warning: shadowed declaration is here graphics.h:129: warning: declaration of =E2=80=98clip_area=E2=80=99 shadows= a global declaration gadgets.h:299: warning: shadowed declaration is here term.c:224: warning: declaration of =E2=80=98xsize=E2=80=99 shadows a globa= l declaration gadgets.h:301: warning: shadowed declaration is here term.c:224: warning: declaration of =E2=80=98ysize=E2=80=99 shadows a globa= l declaration gadgets.h:302: warning: shadowed declaration is here term.c:952: warning: declaration of =E2=80=98angle=E2=80=99 shadows a globa= l declaration eval.h:140: warning: shadowed declaration is here term.c:1185: warning: declaration of =E2=80=98y1=E2=80=99 shadows a global = declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/tek.trm:493: warning: declaration of =E2=80=98y1=E2=80=99 shadows= a global declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/tek.trm:581: warning: declaration of =E2=80=98y1=E2=80=99 shadows= a global declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/tek.trm:585: warning: declaration of =E2=80=98y0=E2=80=99 shadows= a global declaration /usr/include/bits/mathcalls.h:241: warning: shadowed declaration is here =2E./term/x11.trm:528: warning: declaration of =E2=80=98title=E2=80=99 shad= ows a global declaration gadgets.h:326: warning: shadowed declaration is here =2E./term/cgm.trm:102: warning: declaration of =E2=80=98y1=E2=80=99 shadows= a global declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/cgm.trm:728: warning: declaration of =E2=80=98lgh=E2=80=99 shadow= s a previous local =2E./term/cgm.trm:722: warning: shadowed declaration is here =2E./term/cgm.trm:936: warning: declaration of =E2=80=98y1=E2=80=99 shadows= a global declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/emf.trm:790: warning: declaration of =E2=80=98y1=E2=80=99 shadows= a global declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/hp26.trm:92: warning: declaration of =E2=80=98index=E2=80=99 shad= ows a global declaration /usr/include/string.h:304: warning: shadowed declaration is here =2E./term/hp26.trm:111: warning: declaration of =E2=80=98index=E2=80=99 sha= dows a global declaration /usr/include/string.h:304: warning: shadowed declaration is here =2E./term/mif.trm:114: warning: declaration of =E2=80=98y1=E2=80=99 shadows= a global declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/mif.trm:384: warning: declaration of =E2=80=98y1=E2=80=99 shadows= a global declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/pdf.trm:55: warning: declaration of =E2=80=98y1=E2=80=99 shadows = a global declaration /usr/include/bits/mathcalls.h:242: warning: shadowed declaration is here =2E./term/pdf.trm:1041: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1041: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1043: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1043: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1045: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1045: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1047: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1047: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1053: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1053: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1055: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1055: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1057: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1057: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1059: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1059: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1063: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1063: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1065: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1065: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1070: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1070: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1072: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1072: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1074: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1074: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1076: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1076: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1082: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1082: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1084: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1084: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1086: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1086: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1088: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1088: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1094: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1094: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1096: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1096: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1098: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1098: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1100: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1100: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1105: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1105: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1107: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1107: warning: declaration of =E2=80=98y=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1114: warning: declaration of =E2=80=98x=E2=80=99 shadows= a parameter =2E./term/pdf.trm:690: warning: shadowed declaration is here =2E./term/pdf.trm:1114: warning: declaration of =E2=80... [truncated message content] |
|
From: Daniel J S. <dan...@ie...> - 2006-07-18 05:55:41
|
Ethan A Merritt wrote: > If you turn on -Wshadow you'll see a whole lot more than just that one. Ayyy! Confidence is shaken.... Definitely Post-4.2; too easy to miss a name change and instead be pointing to the global variable by mistake. Dan |
|
From: <br...@ph...> - 2006-07-18 18:38:53
|
Daniel J Sebald wrote: > I've probably asked this before, but preceding and trailing white > spaces... should those not be ignored as the code currently does? > gnuplot> load ' histograms.dem' > ^ > Cannot open load file ' histograms.dem' > util.c: No such file or directory > gnuplot> load 'histograms.dem ' > ^ > Cannot open load file 'histograms.dem ' > util.c: No such file or directory Erm... are you sure this question makes sense as written? No, leading and trailing whitespace inside strings should *not* be ignored. If the code currently does that, that's a bug. > For the history readline, the Home key places an "OH" in the line and > the End key places an "OF" in the command line. There's an off chance you can fix that by turning of "application cursor keys" mode in your xterm. |
|
From: <br...@ph...> - 2006-07-18 20:09:07
|
Daniel J Sebald wrote: >> No, leading and trailing whitespace inside strings should *not* be >> ignored. If the code currently does that, that's a bug. > You mean "currently doesn't do that", I think. (I originally framed > the issue as double negative, but so no other way.) No. I meant exactly what I wrote. If blanks *anywhere* inside the delimeters of a string passed to gnuplot get ignored, that's a bug, period. As of the CVS version right now, trailing blanks apparently get ignored at least in the Windows version. That's a bug. IIRC from the earlier discussion, this was found to be an unintentional side effect of the intended tolerance towards forgetting the closing quote. I.e. while it makes some sense to interpret load 'foo.dem (note: two trailing blanks after 'dem', but not closing quote) as load 'foo.dem' and strip those invisible blanks, the same is *not* the case for load 'foo.dem ' "foo.dem " is a legal (though highly unusual) file name on at least some platforms, and it indicates a different file than "foo.dem". It's thus a clear bug if gnuplot can't access that file even though its exact name has been passed by the user. > (Whoever came up with the idea of white space in computer file names? > Ever list a directory with such files? It's downright confusing.) Of course it's confusing. But that's the way it is. Water under the bridge. |
|
From: Ethan M. <merritt@u.washington.edu> - 2006-07-18 20:25:22
|
On Tuesday 18 July 2006 01:10 pm, Hans-Bernhard Br=F6ker wrote: > > As of the CVS version right now, trailing blanks apparently get > ignored at least in the Windows version. That's a bug. Not under linux: gnuplot> set term png gnuplot> set output 'foo.png ' gnuplot> test gnuplot> quit # file foo.png foo.png: cannot open `test.png' (No such file or directory) # file 'foo.png ' foo.png : PNG image data, 640 x 480, 8-bit colormap, non-interlaced I'll have to leave windows-specific bugs to someone else. =2D-=20 Ethan A Merritt Biomolecular Structure Center University of Washington, Seattle WA |
|
From: Daniel J S. <dan...@ie...> - 2006-07-18 19:01:41
|
Hans-Bernhard Br=F6ker wrote: > Daniel J Sebald wrote: >=20 >> I've probably asked this before, but preceding and trailing white >> spaces... should those not be ignored as the code currently does? >=20 >=20 >> gnuplot> load ' histograms.dem' >> ^ >> Cannot open load file ' histograms.dem' >> util.c: No such file or directory >=20 >=20 >> gnuplot> load 'histograms.dem ' >> ^ >> Cannot open load file 'histograms.dem ' >> util.c: No such file or directory >=20 >=20 > Erm... are you sure this question makes sense as written? >=20 > No, leading and trailing whitespace inside strings should *not* be > ignored. If the code currently does that, that's a bug. You mean "currently doesn't do that", I think. (I originally framed the = issue as double negative, but so no other way.) As far as strings are concerned, trailing white space should not be ignor= ed. But when it comes to the point of attempting to open a file, can the= trailing whitespace be ignored?... Oo, I guess I should retract that. = I just attempted to open something in gvim and placed white space before = and after the name. gvim created a new file with spaces instead of openi= ng the file I intended. (Whoever came up with the idea of white space in computer file names? Ev= er list a directory with such files? It's downright confusing.) >> For the history readline, the Home key places an "OH" in the line and >> the End key places an "OF" in the command line. =20 >=20 >=20 > There's an off chance you can fix that by turning of "application curso= r=20 > keys" mode in your xterm. I wondered about that. I see some keyboard settings in my xterm, but not= hing having to do with the end and home keys. I'll investigate. Dan |
|
From: <br...@ph...> - 2006-07-18 20:42:23
|
Ethan Merritt wrote: > On Tuesday 18 July 2006 01:10 pm, Hans-Bernhard Br=F6ker wrote: >> As of the CVS version right now, trailing blanks apparently get >> ignored at least in the Windows version. That's a bug. > Not under linux: >=20 > gnuplot> set term png > gnuplot> set output 'foo.png ' Erm, I was talking about the 'load' command, not 'set output'. But s= ame=20 difference: =09set output 'foo.pbm ' writes a file that's actually called 'foo.pbm'. This *might* be a= =20 feature of the file system or the compiler's runtime lib, though. Th= is=20 is Windows after all... |
|
From: Daniel J S. <dan...@ie...> - 2006-07-18 20:26:33
|
Hans-Bernhard Br=F6ker wrote: > Daniel J Sebald wrote: >=20 >=20 >>>No, leading and trailing whitespace inside strings should *not* be=20 >>>ignored. If the code currently does that, that's a bug. >=20 >=20 >>You mean "currently doesn't do that", I think. (I originally framed >>the issue as double negative, but so no other way.) >=20 >=20 > No. I meant exactly what I wrote. If blanks *anywhere* inside the=20 > delimeters of a string passed to gnuplot get ignored, that's a bug,=20 > period. Right. That is currently how linux works. >=20 > As of the CVS version right now, trailing blanks apparently get ignored= =20 > at least in the Windows version. That's a bug. IIRC from the earlier=20 > discussion, this was found to be an unintentional side effect of the=20 > intended tolerance towards forgetting the closing quote. I.e. while it= =20 > makes some sense to interpret >=20 > load 'foo.dem >=20 > (note: two trailing blanks after 'dem', but not closing quote) as >=20 > load 'foo.dem' >=20 > and strip those invisible blanks, the same is *not* the case for >=20 > load 'foo.dem ' If blanks are to matter, I contend that invisible blanks should not be st= rip even in the case of load 'foo.dem =20 Because then one could argue that the following load 'foo dem should be interpretted as load 'foo' dem >=20 > "foo.dem " is a legal (though highly unusual) file name on at least som= e=20 > platforms, and it indicates a different file than "foo.dem". It's thus= =20 > a clear bug if gnuplot can't access that file even though its exact nam= e=20 > has been passed by the user. There may be a bug in the Windows version. I don't have Windows access. Dan |
|
From: Ethan M. <merritt@u.washington.edu> - 2006-07-18 20:36:23
|
On Tuesday 18 July 2006 01:35 pm, Daniel J Sebald wrote: > Hans-Bernhard Br=F6ker wrote: > > Daniel J Sebald wrote: > >>>No, leading and trailing whitespace inside strings should *not* be > >>>ignored. If the code currently does that, that's a bug. > >> > >>You mean "currently doesn't do that", I think. (I originally > >> framed the issue as double negative, but so no other way.) > > > > No. I meant exactly what I wrote. If blanks *anywhere* inside the > > delimeters of a string passed to gnuplot get ignored, that's a bug, > > period. > > Right. That is currently how linux works. > If blanks are to matter, I contend that invisible blanks should not > be strip even in the case of > > load 'foo.dem > > Because then one could argue that the following > > load 'foo dem > > should be interpretted as > > load 'foo' dem I argue that it should be considered a syntax error, and not interpreted at all. I have never like the "closing quote optional" behavior. =2D-=20 Ethan A Merritt Biomolecular Structure Center University of Washington, Seattle WA |
|
From: Daniel J S. <dan...@ie...> - 2006-07-18 20:54:33
|
Ethan Merritt wrote: >>load 'foo' dem > > > I argue that it should be considered a syntax error, and > not interpreted at all. > > I have never like the "closing quote optional" behavior. Well, I agree with you there. I've gotten in this bad habit of leaving off that final quotation. (And to be honest, not realizing I had a space after the name because there was no closing quote is what lead to my inquiry.) Dan |
|
From: Petr M. <mi...@ph...> - 2006-07-18 21:14:01
|
> I have never like the "closing quote optional" behavior. I like it! --- PM |