Re: [Freedos-kernel] 32RTM Bug Found, no good fix

[Luchezar G. <lu...@co...>]

Thank you very much, Michael, for your discovery of the 32RTM bug!

> There you have it folks.  A dumb bug in a Borland product that by purest 
> happenstance fails under FreeDOS and not MS-DOS.  I don't have any idea 
> how to gracefully fix the problem other than to have FreeDOS change its 
> serial number.  And it shouldn't have to do that.

Sure. But since it's easier to make the kernel return a serial mumber of 0 
as MS-DOS does than to patch each and every copy of 32RTM.EXE, I changed 
our function 30h to return 0 in CX. I tested this change and now 32RTM 
works without -X as Michael wrote indeed! So I uploaded a new unstable 
kernel binary at http://linux.tu-varna.acad.bg/~lig/freedos/kernel/ along 
with a comulative patch (CVSPATCH.TXT) for the unstable branch consisting 
of the Eduardo's NLS patch and the following patch. Thus, regrettably 
we're back to version 0.0.35 now (as reported by the FreeCOM's VER /R ;-)

I guess 32RTM now stands for "32 times Read The Manual!" ;-)

Do you see now what I meant when I wrote that MS-DOS has a better "bug 
compatibility"? ;-)

Regards,
Lucho

--- cvs/kernel/kernel/inthndlr.c	2004-07-25 20:12:50.000000000 +0200
+++ src/kernel/kernel/inthndlr.c	2004-08-13 12:05:56.000000000 +0200
@@ -698,10 +698,8 @@
      case 0x30:
        lr.AL = os_setver_major;
        lr.AH = os_setver_minor;
-      lr.BH = OEM_ID;
-      lr.CH = REVISION_MAJOR;   /* JPP */
-      lr.CL = REVISION_MINOR;
-      lr.BL = REVISION_SEQ;
+      lr.BX = (OEM_ID << 8) | REVISION_SEQ;
+      lr.CX = 0; /* serial number must be 0 or buggy 32RTM thrashes 
stack! */

        if (ReturnAnyDosVersionExpected)
        {