From: Kenneth J. D. <je...@fd...> - 2012-03-10 00:01:10
|
On Mon, Mar 5, 2012 at 2:24 PM, Kenneth J. Davis <je...@fd...> wrote: > On Mon, Mar 5, 2012 at 2:13 AM, dos386 <do...@gm...> wrote: > ... >> >> Minor SYS BUG (see shot): it fails to find KERNEL.SYS despite it's >> in there (it has "R" attribute). Suggestion for improvement: >> >> - read and report KERNEL.SYS attribs and size >> - if "R" then write "can't modify because read-only" >> - IF ((not "R") AND (modification requested)) THEN >> - - open with write access >> - ELSE >> - open with read access only >> - ENDIF >> > > Thank you for the bug report, I will try to look into and provide an > updated version later this week (see below). > >> Other thing somewhat "missing" is reading out the version info Please see attached patch for review. For sys config: (fdkrncfg.c) adds support for displaying current config options if kernel can not be opened for writing, will display a warning if attempt to update changes on read-only kernel (while still validating command line arguments). Also included is a patch to add a minimal version resource to kernel: oem id, major # (e.g. 2), minor # (e.g. 41), and if svn or release build (svn version may include svn revision#) along with support for sys config to display version information if found. Note: when upx is used the size of the config block is wrong, so values should be tested against "unused87654321" (or since config block has not really changed much, can assume if 19 bytes in size then really not more than 14 are valid (though could be less)). The attached patch does not include changes for config block created in upx'd kernel (requires update to exeflat.c). Attached changes create a config block that is 20 bytes in size. Other part of fdkrncfg.c patch adjusts spacing of help text to make help output more consistent. Thank you, Jeremy |