#3286 Title "King" is still used sometimes
The game seems to want to prefer the title "Monarch" instead of King (because of Queen Elizabeth I.).
This is good, but apparently there are a few strings in which the game still uses the title "King", which is wrong if you play as England. This is probably an accident. Here are the offending strings:
Conquered native settlements always yield treasure (and in greater abundance) and the King's galleons transport it free of charge.
The King's foreign wars no longer have effect on relationships in the New World and Europeans in the New World always offer peace in negotiations.
Your king will transport your treasure to Europe at NO EXTRA CHARGE (except taxes)!
The King is boycotting these goods until you have paid your tax arrears of %amount% gold. Do you wish to do so now?
There are also two more tricky texts:
Long live the King!
King's Regular
Suggestion to fix this: Replace the title "King" with "monarch" in each of these strings. The biggest question, however, is how the King's Regular unit should be renamed (if at all). I have no good idea for now.
But "Long live the King!" might be changed to "Long live the Queen!" or "God save the Queen!" for the England nation only. :D Either that, or just replace it with a generic "Hurrah!".
Version: 0.13.0-dev, commit cb10784763ce2a594dc5333ba83a56e197bc4e19.
Mostly agreed. I have replaced king with "monarch" and "crown" in several of these cases, and thank you for the "Hurrah!" suggestion. However I am inclined to leave "Kings Regular" alone as they were in Col1, and individual regiments have connections to specific monarchs who may not necessarily be alive, so this is not necessarily wrong even when the monarch of the day is female.
See git.7a914ea.
This looks good, and "King's Regular" seems like a reasonable exception.