#3182 New Game Map Selection Window bug & issues

[Blake]

1. Having more maps has revealed a small bug with the map viewer window. When more than 4 maps are there a scroll bar appears. However whoever setup the window did not take this scroll bar into account when setting the window size so as a result the map titles get cropped even if the title is short.

2. Also it would be handy if the game didn’t put “freecol map” in front of every map name as that stretches the map selector boxes out reducing the amount of maps that can be displayed in the window at one time. See attached screenshot.

[Mike Pope]

1. Fair call, the code that sizes that panel had a comment "FIXME: Work out how to do this properly". I do not claim to have definitely done that, but it is working better for me following git.2a49521.

2. I think you have misunderstood the purpose of the freecol.map prefix here. FreeCol is using the values I see displayed in the screenshot as lookup keys into the translation database. Since you have changed the keys from the ones it understand (e.g. freecol.map.Australia) the lookup fails and freecol is defaulting to just displaying the lookup key. What you need to do is hunt down the master translation file (FreeColMessages.properties), in there you will find a small section for MapGeneratorOptionsDialog, where a bunch of key,value pairs are defined in the form

freecol.map.map-file-name=Name of the map that you want to display in English

Keep the map-file-name part simple (no spaces!). Indeed I would not even rename the exsiting ones, and just add simple new ones like "Australia2.fsm". The size and author credit goes on the RHS of the equals sign.

Apologies for the delay getting to this. Sick as over the weekend.

[Blake]

Urgh.. this stuff's a bit over my head mate. I didn't change any prefix settings wherever that stuff is your talking about.. I just loaded the maps in the map editor and resaved them to refresh the thumbnails with the better modern ones. Then I renamed the file names into something more descriptive and that sorts better as the old names really aren't going to work well as more and more maps are added from different people.

Is my incompotible names what's causing the weird errors in my pull request? (that I asked for help on in the forums and in the dev mailing list a month ago) here:
https://github.com/FreeCol/freecol/pull/56

I can rename the files to something better but hunting down master translation stuff somewhere in something.. umm yeah.. I got no idea sorry.

Was trying to help but I guess I just made more problems lol.

[Marcin]

It does work better now. I suppose you simply increased the height of the window? It fixed the problem :)
This screen has plenty of space. It is not very clean looking like this.

[Blake]

cool.. cheers for fixing the heigh thing Mike.

[Mike Pope]

Its working. Not pretty, but working:-). Setting to Pending.