Game does not run on macOS Catalina 10.15.1. Game icon has a circle with diagonal bar across. My guess (and it's just a guess) is that the game is not 64-bit, since that is what has broken a lot of other games in Catalina.
I don't use MacOS, but it should just be the launcher or installed JRE having a problem, because FreeCol is a Java game.
As a workaround, please get the platform-agnostic .jar version of FreeCol and install a working (64 bit) version of Java beforehand.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I can verify that it does run on Mac OS 10.15, though you do need to to have an updated 64-bit version of Java to run it.
However, I think there is still one issue with the ant target 'macJavaBundle' in the main build.xml file - the mainclass= attribute in the <jarbundler> element should be "net.sf.freecol.FreeCol" rather than "net.sf.freecol.freecol" or the program won't start correctly. I've attached a patch against current git head to make this change.</jarbundler>
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thank you for testing and the patch.
I'm not sure I understood the second paragraph completely. You just think this change would be necessary or you verified it is necessary for the current MacOS? I mean up until now, it should have ran for other people, or not cause there is so few people trying it on a Mac? Just trying to be careful, because we have no Mac developer who could test.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I just built from the latest git sources, and there's some more (beyond the patch) that needs to be done to make the 'tarMacJavaBundle' target work correctly.
I'm not sure why other Mac users haven't seen it; though they may be using the platform independent installer instead of compiling from source and installing the application bundle.
Anyway, I have three different Macs I can test this with. I'll verify on each one that the current git master doesn't build this correctly, then make sure that the build.xml changes along with adding the universalJavaApplicationStub to build/skeletons will fix it and allow building of a working app bundle.
I'll send a pull request when I'm done. Thanks, Wintertime!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
OK, I've made the changes to make this work. You can see the pull request; I hope I've dotted all the i's and crossed all the t's correctly.
I discuss some other issues with making this work "out of the box" on MacOS in the pull request; with some guidance I may be able to have it create the ~/Library/Preferences/freecol subdirectory automatically upon startup. Looks like src/net/sf/freecol/common/io/FreeColDirectories.java is the key source file.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I don't use MacOS, but it should just be the launcher or installed JRE having a problem, because FreeCol is a Java game.
As a workaround, please get the platform-agnostic .jar version of FreeCol and install a working (64 bit) version of Java beforehand.
Which version of FreeCol are you using, btw.?
Last edit: wintertime 2019-12-16
I can verify that it does run on Mac OS 10.15, though you do need to to have an updated 64-bit version of Java to run it.
However, I think there is still one issue with the ant target 'macJavaBundle' in the main build.xml file - the mainclass= attribute in the <jarbundler> element should be "net.sf.freecol.FreeCol" rather than "net.sf.freecol.freecol" or the program won't start correctly. I've attached a patch against current git head to make this change.</jarbundler>
Thank you for testing and the patch.
I'm not sure I understood the second paragraph completely. You just think this change would be necessary or you verified it is necessary for the current MacOS? I mean up until now, it should have ran for other people, or not cause there is so few people trying it on a Mac? Just trying to be careful, because we have no Mac developer who could test.
Well...
I just built from the latest git sources, and there's some more (beyond the patch) that needs to be done to make the 'tarMacJavaBundle' target work correctly.
I'm not sure why other Mac users haven't seen it; though they may be using the platform independent installer instead of compiling from source and installing the application bundle.
Anyway, I have three different Macs I can test this with. I'll verify on each one that the current git master doesn't build this correctly, then make sure that the build.xml changes along with adding the universalJavaApplicationStub to build/skeletons will fix it and allow building of a working app bundle.
I'll send a pull request when I'm done. Thanks, Wintertime!
OK, I've made the changes to make this work. You can see the pull request; I hope I've dotted all the i's and crossed all the t's correctly.
I discuss some other issues with making this work "out of the box" on MacOS in the pull request; with some guidance I may be able to have it create the ~/Library/Preferences/freecol subdirectory automatically upon startup. Looks like src/net/sf/freecol/common/io/FreeColDirectories.java is the key source file.
Don's PR was merged in git.182376b. Testing welcome.
No further signal here, looks like the fix was good. Setting to Pending.