I just had this problem with a new game on git.f4aca10f, to not be able to sail back to the new world. I only got server can not do that and there is the warning of the high seas not being connected inside the log.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I can test it no problem. However I normally start from Weekly Releases which are ready to roll. I am not sure how to test one fix. It looks like it was merged after last weekly so once next weekly is created I can test from there.
Last edit: Marcin 2019-12-20
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I merged GitHub PR#45 now, as it helped. If your ship is already in Europe it may still be bugged.
You can use the new nightly I just started for further testing.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Many thanks for the testing Marcin. I was up to about BR#3142 when I had to step back from FreeCol work last year, so checking older bugs than that (like this one) is the most helpful, as they are the ones that are either believed fixed or needing more information. I am just starting to work on BR#3142 today.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think I found the issue.
In the code we throw a NPE because the owner of the unit does not have a entryLocation set.
The entryLocation issue is known and partly understood. I hope to beback to working on it by the weekend.
git.8ac53e7 should fix it. Did that work for you?
I don't see git.8ac53e7
do you mean
https://github.com/FreeCol/freecol/pull/7
that works for me
Adrian, just build latest git master version.
for details about that commit see https://sourceforge.net/p/freecol/git/ci/8ac53e7b639ca9ae5d88cdc9a802dfccaa63dca4/
Gah, I am sorry, I completely forgot about this. I've got a lot of things to do.
Regardless, I'll test this out sometime this week.
I just had this problem with a new game on git.f4aca10f, to not be able to sail back to the new world. I only got server can not do that and there is the warning of the high seas not being connected inside the log.
Related issues:
https://github.com/FreeCol/freecol/issues/44
https://github.com/FreeCol/freecol/pull/45
New duplicate bug:
https://sourceforge.net/p/freecol/bugs/3177/
I can test it no problem. However I normally start from Weekly Releases which are ready to roll. I am not sure how to test one fix. It looks like it was merged after last weekly so once next weekly is created I can test from there.
Last edit: Marcin 2019-12-20
I merged GitHub PR#45 now, as it helped. If your ship is already in Europe it may still be bugged.
You can use the new nightly I just started for further testing.
Tested in new Weekly. It works fine. Will do few more test and confirm but initial one went ok.
Tested in 2019-12-29. Fixed.
Many thanks for the testing Marcin. I was up to about BR#3142 when I had to step back from FreeCol work last year, so checking older bugs than that (like this one) is the most helpful, as they are the ones that are either believed fixed or needing more information. I am just starting to work on BR#3142 today.
This is related: https://sourceforge.net/p/freecol/bugs/3167/
Someone commented there he did some bisecting on the bug and found the commit.
The next fix for this (and BR#3167) is in git.58660f4a. The patch survived overnight testing but there are some things I am not sure about still.
Looks like it worked, setting to Pending.