#3109 Unable to trade with "Unknown" city

[vasya novikov]

Steps to reproduce:
. create a ship with 50 muskets on it (and no units)
. move the ship to a native settlement you haven't traded before
. try to move the ship to the settlement. Nothing will change visually
. tro to move the ship to the settlement again. Now you'll have an error:

net.sf.freecol.server.model.ServerPlayer clientError
    WARNING: Session already open for: [nativeTrade unit:6275 indianSettlement:5837 buy=true sell=true gift=true count=0 item=null unitToSettlement[] settlementToUnit[ ]]

Note the "session already open" thing. I guess this means that the server actually thought we started trading at our first attempt.

[vasya novikov]

Attached savegame. Load it, select ship, move to the left twice (into native settlement).

[Mike Pope]

There was a mishandling of the restriction that you can not trade with a ship to an uncontacted native settlement. Should be fixed in git.210a8e9, in that now nothing will happen.

[vasya novikov]

Confirming, it's fixed. Thank you!

[Mike Pope]

Thanks, closing.