Incorrect Error message when trying to unload more then available amount

Colonize the New World.

Brought to you by: burschik, mpope, pruano, stiangre

#3107 Incorrect Error message when trying to unload more then available amount

Milestone: Fixed_0.12.0

Status: closed-out-of-date

Owner: nobody

Labels: None

Priority: 1

Updated: 2022-05-01

Created: 2017-10-25

Creator: vasya novikov

Private: No

Steps to reproduce:
. have a ship in Europe with 100Cotton and 30Cotton
. Shift+click on Cotton, move it from the ship to Europe ("down")
. select a value of 200 (intention to move/sell 200 cotton to Europe)

Expected: a GUI explanation why it's not possible

Actual: "Server can't do that", a weird log file etc.

P.S. I'm not sure how developers feel about this thing. If you think this should be closed, you may close the issue.

Discussion

Lone_Wolf - 2017-10-25

That error usually appears when client and server are out of sync.
It signifies a problem in the code that needs to be investigated, but to do that we need
the savegame and log file.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- vasya novikov - 2017-10-25
  
  Exactly. This should only appear on OOS or other kinds of exceptions. But instead it happens "normally" when you unload more than you have.
  
  BTW, I re-tested the steps above, and it actually happens when unloading any kind of cargo anywhere. Like unloading 2 food from a ship that only has 1 food. Or from Wagon. It reproduces 100%.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- vasya novikov - 2017-10-28
  
  If the issue gets confirmed, please remove the "needs more info" status..
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Lone_Wolf - 2017-10-25

status: open --> open-needs-info
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Lone_Wolf - 2017-10-28

Confirmed.

This error does not have to do with sync issues , but looks like a corner case in unload goods handing.

When using shift+click , manually type in a bigger number then available to trigger this bug.
savefile and log with latest trunk attached.

Last edit: Lone_Wolf 2017-10-28

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Mike Pope - 2017-11-12
  
  When using shift+click , manually type in a bigger number then available to trigger this bug.
  
  Agreed that this is the problem. I am somewhat surprised it works, so kudos to Vasya for spotting this. The amount of goods present is clearly available in the dialog so we should be able to prevent entering an invalid value. Looking at this next.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Mike Pope - 2017-11-13
    
    Added an InputValidator to the combobox in git.69161b5. AFAICT now if you enter an invalid amount, it is quietly ignored without crash or consequence.
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Lone_Wolf - 2017-10-28

summary: Error message "Server can't do that" unnecessary while unloading --> Incorrect Error message when trying to unload more then available amount
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Lone_Wolf - 2017-10-28

title changed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Lone_Wolf - 2017-10-28

status: open-needs-info --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mike Pope - 2017-11-13

status: open --> open-needs-info
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

vasya novikov - 2017-11-14

still can't unload tools at all no matter how from Dutch starting Merchantman ship. Somewhy it doesn't work with the recent commits. Tested on commit 271facbfd7f3690d518009357dc61a965655d029
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Mike Pope - 2017-11-14
  
  I am having no such trouble. Something very odd is happening for you. Please supply more detail (log file, save game, or even the terminal output in COMMS debug mode).
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mike Pope - 2022-04-24

status: open-needs-info --> closed-out-of-date

Group: Current --> Fixed_trunk
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mike Pope - 2022-04-24

Another non-reproduceable bug that has gone quiet.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mike Pope - 2022-05-01

Group: Fixed_trunk --> Fixed_0.12.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.