Steps to reproduce:
. start freecol
. click "Open", select any map (it has *.fsg extension)
. click OK
. a dialog will appear, "Loading Save Game". Press Cancel.
You will have a completely empty window of freecol now, nothing is clickable.
a dialog will appear, "Loading Save Game". Press Cancel.
Not seeing this with the games from my save directory that I see in the dialog that pops up after "Open". However I am unclear on this:
Click "Open", select any map (it has *.fsg extension)
When you say "select any map", do you mean that you are trying to select one of the 4 (now 5) predefined maps? I am not sure that is intended to work. Maps are not games. They are incomplete.
Did you have to navigate to the map directory to find them or were they offered by default?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Well yes. But this is what I do anyway. I create a map (any map at all), and then try to open it as a game. The UI allows me doing that.
Did you have to navigate to the map directory to find them or were they offered by default?
Yes, they are/were offered by default. Actually, I don't even have a "map" directory, so IDK what you're talking about, exactly. When I start "Map Editor" and click "Save", the save directory is offered by default. So I click OK and save to this directory. And later load from this directory.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Well yes. But this is what I do anyway. I create a map (any map at all), and then try to open it as a game. The UI allows me doing that.
Perhaps it should not. Indeed, ATM it is not allowing it:-). There is one place where you can do what you are trying, which is in the map editor menu, where there is a bunch of special case code that is frequently broken. AFAICT the general "Open" menu entry was only ever intended to open a fully created game.
I don't even have a "map" directory
I was referring to the place in the freecol installation data directory where the standard 4/5 maps are installed. I am pretty sure you must have one of them somewhere.
When I start "Map Editor" and click "Save", the save directory is offered by default. So I click OK and save to this directory. And later load from this directory.
OK, that is clearer. What would probably be best here then is to have the map editor save maps to a user maps directory so this confusion can be avoided. And also for better error handling if you do try to play a map when a game is expected.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
confirmed, log attached
Not seeing this with the games from my save directory that I see in the dialog that pops up after "Open". However I am unclear on this:
When you say "select any map", do you mean that you are trying to select one of the 4 (now 5) predefined maps? I am not sure that is intended to work. Maps are not games. They are incomplete.
Did you have to navigate to the map directory to find them or were they offered by default?
Well yes. But this is what I do anyway. I create a map (any map at all), and then try to open it as a game. The UI allows me doing that.
Yes, they are/were offered by default. Actually, I don't even have a "map" directory, so IDK what you're talking about, exactly. When I start "Map Editor" and click "Save", the
savedirectory is offered by default. So I click OK and save to this directory. And later load from this directory.Perhaps it should not. Indeed, ATM it is not allowing it:-). There is one place where you can do what you are trying, which is in the map editor menu, where there is a bunch of special case code that is frequently broken. AFAICT the general "Open" menu entry was only ever intended to open a fully created game.
I was referring to the place in the freecol installation data directory where the standard 4/5 maps are installed. I am pretty sure you must have one of them somewhere.
OK, that is clearer. What would probably be best here then is to have the map editor save maps to a user maps directory so this confusion can be avoided. And also for better error handling if you do try to play a map when a game is expected.
This is now the case as of git.8cbcc64.
I plan to rename all maps from name.fsg to name.fsm to further emphasize that maps are not games.
Renaming has occurred. This mistake should now be harder to make.