#3099 Incorrect updates for colony view, tile and building production

[vasya novikov]

Steps to reproduce:
open any game or start a new one
open any colony
* move any colonist from one place to another (for example, between tiles).

Expected at this moment:
the colonist should visually be erased from the old place
the old tile/building production should be updated visually (erased)

Actually:
* old production remains, old colonis image remains. Also, production bonuses travel between buildings/tiles. Like you can see a visual presentation of grass production on Town Hall, or bells under grassland tile.

Introduced in this commit (I bisected to find the faulty one): 549b504f6f05ed70aee23017976cd9acecc3d669

[vasya novikov]

I've set a wrong milestone. It's NOT fixed in the master branch, it's still present. Probably "Milestone" should be set to "current". I'm not sure about the terminology.

[Lone_Wolf]

That would be this commit :
https://sourceforge.net/p/freecol/git/ci/549b504f6f05ed70aee23017976cd9acecc3d669/

as for milestone : just leave that as-is when you create a bug, so current.

issue confirmed .
In attached savegame i opened the colony Eindhoven and moved the lower right farmer to the lumber mill .
closing and re-opening the colony view did show correct info

[Mike Pope]

That commit was a big change. Breakage is unsurprising. The problem here was fixed in passing in git.f44c0a3. Please let us know if there are still cases occurring.

[vasya novikov]

Mike, the bug is indeed fixed now. Issue can be closed. Thank you!

[Mike Pope]

OK, closing.