(maybe this occurs only in Linux versions - I use opensuse 13.2)
If you want to edit a river tile and select a specific river style from the river style dialog this style is not set - instead in all cases (except Delete) style "1111" or "2222" (4 branches) is applied. (See highlighted tile)
From Version 0.10.7 the map editor has inherited the auto-connecting of river branches. That is very annoying, if you want to edit rivers manually.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry, the map editor got a number of quirks (as there is only very few people working on FreeCol), many known like the large river style dialog. I was unsure how to change it as the images are small already and making it wider would cover a whole screen in a smaller resolution.
You might be able to move it up a bit to see the bottom, but unlike the game it needs at least 1080 pixel height.
Be careful with combined save+quit as it might exit before the save is complete; save, wait, only then quit!
Last edit: wintertime 2015-11-30
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think scrollbar woud be nice in this situation. Also it may be worth not packing the "delete" button with tiles buttons so user won't need to scroll if he wants to delete something.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I found what was wrong with 2. The dialog with the river styles did not format the style key correctly, which made the method for updating the river connections malfunction silently.
I fixed that in git.ca785697.
I feel its still problematic usability in that the dialog suggests you could set the style and then it instead updates it. I also suspect the display may not be updated immediately for all changes.
Last edit: wintertime 2016-11-10
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
There is now a serarate button for editing river styles, which opens the river style menu --without the delete button.
Right click when having selected the old river buttons only adds and removes a river of the selected size, depending on if there is one already, same as most other buttons work in the map editor.
I added these changes in git.3d32e183.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thank you for the new code. I compiled the develloper version and tested the new river style dialog. The dialog with the river-edit-button now works fine, but river style menu is still too big. On my 1920x1080 screen it is 679x1222 px.
I think it is also good idea to deactivate automatically river-edit-button after a tile has been edited. So you can prevent editing unwanted tiles.
While running several tests, I discovered that if you have a little complex game (more than ~ 6 cities) and you save this within the mapeditor, the resulting map file is not correctly saved. In the standard 0.11.6 version this works fine.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Yes, we were debating filtering out duplicate/unsupported river styles or changing the code to support them. I pushed a fix filtering out combined minor/major rivers as they are not supported currently and minor rivers as their buttons would currently result in the same transform as the buttons with a major river style. Its in git.141d08b9.
It allows you to edit multiple tiles styles after choosing one, if you want to change other tiles to a different style you can click the button twice, clicking once deactivates it. I think thats better than automatically deactivating, as you saw how annoying it was to choose a style each time you click a tile before I moved that to a separate button.
PS: Please, create separate BRs for new problems, as it makes tracking them easier! I'll copy the last paragraph into a new BR this time and set this BR to fixed.
Last edit: wintertime 2017-02-06
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Its there: https://sourceforge.net/p/freecol/bugs/3025/
Please, report any more information you have on the new bug (for example: where you got that save from, what you did, log file, the save, if existing the incorrectly saved save)!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
(maybe this occurs only in Linux versions - I use opensuse 13.2)
From Version 0.10.7 the map editor has inherited the auto-connecting of river branches. That is very annoying, if you want to edit rivers manually.
Sorry, the map editor got a number of quirks (as there is only very few people working on FreeCol), many known like the large river style dialog. I was unsure how to change it as the images are small already and making it wider would cover a whole screen in a smaller resolution.
You might be able to move it up a bit to see the bottom, but unlike the game it needs at least 1080 pixel height.
Be careful with combined save+quit as it might exit before the save is complete; save, wait, only then quit!
Last edit: wintertime 2015-11-30
I think scrollbar woud be nice in this situation. Also it may be worth not packing the "delete" button with tiles buttons so user won't need to scroll if he wants to delete something.
Adding tags as needed.
I found what was wrong with 2. The dialog with the river styles did not format the style key correctly, which made the method for updating the river connections malfunction silently.
I fixed that in git.ca785697.
I feel its still problematic usability in that the dialog suggests you could set the style and then it instead updates it. I also suspect the display may not be updated immediately for all changes.
Last edit: wintertime 2016-11-10
There is now a serarate button for editing river styles, which opens the river style menu --without the delete button.
Right click when having selected the old river buttons only adds and removes a river of the selected size, depending on if there is one already, same as most other buttons work in the map editor.
I added these changes in git.3d32e183.
Thank you for the new code. I compiled the develloper version and tested the new river style dialog. The dialog with the river-edit-button now works fine, but river style menu is still too big. On my 1920x1080 screen it is 679x1222 px.
I think it is also good idea to deactivate automatically river-edit-button after a tile has been edited. So you can prevent editing unwanted tiles.
While running several tests, I discovered that if you have a little complex game (more than ~ 6 cities) and you save this within the mapeditor, the resulting map file is not correctly saved. In the standard 0.11.6 version this works fine.
Yes, we were debating filtering out duplicate/unsupported river styles or changing the code to support them. I pushed a fix filtering out combined minor/major rivers as they are not supported currently and minor rivers as their buttons would currently result in the same transform as the buttons with a major river style. Its in git.141d08b9.
It allows you to edit multiple tiles styles after choosing one, if you want to change other tiles to a different style you can click the button twice, clicking once deactivates it. I think thats better than automatically deactivating, as you saw how annoying it was to choose a style each time you click a tile before I moved that to a separate button.
PS: Please, create separate BRs for new problems, as it makes tracking them easier! I'll copy the last paragraph into a new BR this time and set this BR to fixed.
Last edit: wintertime 2017-02-06
Its there: https://sourceforge.net/p/freecol/bugs/3025/
Please, report any more information you have on the new bug (for example: where you got that save from, what you did, log file, the save, if existing the incorrectly saved save)!
Yes, the solution now works fine. Thank you for your patience.