#2767 4 Units appear when Immigrants/Emigrants are chosen

[Calebrw]

Built from [29e85f].

There are always four immigrants/emigrants available and the fourth is always a Jesuit Missionary. You cannot select the Jesuit Missionary.

Formerly, selecting the Jesuit Missionary produced a server error, but now it does nothing.

[Mike Pope]

Once again, I can not reproduce this. How about a saved game?

BTW there is a feature request to make the number of emigrants configurable, and work was even started on this a while back, but never completed. That may be related but it is odd for it to only surface now.

[Calebrw]

This should be the autosave just before that.

I'll try running the game on my laptop running vanilla 0.11.1 too and see if it could be the result of a configuration change on my desktop.

[Calebrw]

I wasn't able to trigger a FOY or immigration choice, so I'll just try it on a new game.

[Calebrw]

With:

FreeCol game version: 0.11.1 (Revision: 0980a62)
FreeCol protocol version: 0.1.6

Java vendor: Oracle Corporation
Java version: 1.7.0_51
Java WM name: Java HotSpot(TM) Client VM
Java WM vendor: Oracle Corporation
Java WM version: 24.51-b03

OS name: Windows 8
OS architecture: x86
OS version: 6.2

Selecting the fourth unit (Jesuit Missionary) results in the follow error.

net.sf.freecol.common.networking.DOMMessage clientError
WARNING: Invalid slot for normal migration.
Wed Dec 10 11:24:16 CST 2014
Thread: 2893
net.sf.freecol.common.networking.ServerAPI askExpecting
WARNING: ServerAPI. emigrateUnit error, messageId: server.reject message: Invalid slot for normal migration.
Wed Dec 10 11:24:16 CST 2014
Thread: 2891

[Mike Pope]

The autosave game contains a Europe with 4 recruits, which explains what you are seeing. It does not explain how that happened. However it is easy enough to tighten the code so that it can not recur, and in the process I have made a bunch of improvements that move closer to parameterizing the number of units. This has been committed in git.beeefee should fix the problem.

[Calebrw]

I have done a single test compiling [4dad7b] and Brewster seems to be broken now. I was able to get immigrants to come to the docks on their own (through normal cross generation), but I had no choice in the matter as to what immigrant i wanted. I'll have to conduct further test when wintertime is done committing changes.

[Calebrw]

Looks fixed to me. Both Brewster and FOY.